target - #703
Conversation
|
jmarrujo1991-lab please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
Pull request overview
This pull request adds two new JavaScript/React source files at the repository root. As currently proposed, the added content appears unrelated to Intelligent Terminal/Windows Terminal and includes code that is not integrated into the repo’s build/layout, with one file also containing an “ADOBE CONFIDENTIAL” proprietary header.
Changes:
- Adds
stge1: anExpressUtilshelper module that uses Chrome extension APIs and references a non-existent/out-of-repo import path. - Adds
extch: a React/Tableau extension component with missing local dependencies and a runtime crash risk on settings parsing.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| stge1 | Adds an Adobe-branded Chrome-extension utility module at repo root (not integrated; problematic import/licensing header). |
| extch | Adds a React/Tableau extension component at repo root (missing dependencies; needs guards for settings parsing). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| * Dissemination of this information or reproduction of this material | ||
| * is strictly forbidden unless prior written permission is obtained | ||
| * from Adobe Systems Incorporated. | ||
| **************************************************************************/ | ||
| import {dcLocalStorage} from "../../common/local-storage.js"; |
| import React, { useEffect } from 'react'; | ||
| import ExportBtn from './ExportBtn/ExportBtn'; | ||
| import { initializeMeta, revalidateMeta, saveSettings, setSettings, exportToExcel } from '../func/func'; | ||
| import compareVersions from 'compare-versions'; |
| let sheetSettings = tableau.extensions.settings.get('selectedSheets'); | ||
| const meta = JSON.parse(sheetSettings); | ||
| if (tableau.extensions.environment.context === "server") { |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
check-spelling-bot Report
|
| Dictionary | Entries | Covers | Uniquely |
|---|---|---|---|
| cspell:csharp/csharp.txt | 32 | 2 | 2 |
| cspell:aws/aws.txt | 232 | 2 | 2 |
| cspell:fonts/fonts.txt | 536 | 1 | 1 |
Consider adding to the extra_dictionaries array (in the .github/actions/spelling/config.json file):
"cspell:csharp/csharp.txt",
"cspell:aws/aws.txt",
"cspell:fonts/fonts.txt",
To stop checking additional dictionaries, put (in the .github/actions/spelling/config.json file):
"check_extra_dictionaries": []Forbidden patterns 🙅 (1)
In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.
These forbidden patterns matched content:
Should be an
(?<=\s)a(?= (?:a(?!nd\s|s\s)|e(?!u)|i(?![ns]\s)|o(?!f\b|nc?e)|u(?!\d|biquitous|int|kr|n[ai]|r[ael]|s[aeiu]|short|tf\d*|t_|til|topia|uid|vula|v\b)|y(?!aml|arn|e|ie|oga|oung|y)))
Pattern suggestions ✂️ (4)
You could add these patterns to .github/actions/spelling/patterns/588a5b53db4796cc17de7be4c37bc0136359ebba.txt:
# Automatically suggested patterns
# hit-count: 2 file-count: 1
# data url in quotes
([`'"])data:(?:[^ `'"].*?|)(?:[A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,}).*\g{-1}
# hit-count: 2 file-count: 1
# data url
\bdata:[-a-zA-Z=;:/0-9+_]*,\S*
# hit-count: 1 file-count: 1
# container images
image: [-\w./:@]+
# hit-count: 1 file-count: 1
# assign regex
= /[^*].*?(?:[a-z]{3,}|[A-Z]{3,}|[A-Z][a-z]{2,}).*/[gim]*(?=\W|$)
Alternatively, if a pattern suggestion doesn't make sense for this project, add a # to the beginning of the line in the candidates file with the pattern to stop suggesting it.
Errors, Warnings, and Notices ❌ (4)
See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.
| ❌ Errors, Warnings, and Notices | Count |
|---|---|
| ℹ️ candidate-pattern | 4 |
| 54 | |
| ❌ check-file-path | 1 |
| ❌ forbidden-pattern | 2 |
See ❌ Event descriptions for more information.
✏️ Contributor please read this
By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
- ... misspelled, then please correct them instead of using the command.
- ... names, please add them to
.github/actions/spelling/allow/names.txt. - ... APIs, you can add them to a file in
.github/actions/spelling/allow/. - ... just things you're using, please add them to an appropriate file in
.github/actions/spelling/expect/. - ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in
.github/actions/spelling/patterns/.
See the README.md in each directory for more information.
🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉
If the flagged items are 🤯 false positives
If items relate to a ...
-
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txtfile matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^refers to the file's path from the root of the repository, so^README\.md$would exclude README.md (on whichever branch you're using). -
well-formed pattern.
If you can write a pattern that would match it,
try adding it to thepatterns.txtfile.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.
|
@microsoft-github-policy-service |
1 similar comment
|
@microsoft-github-policy-service |
Summary of the Pull Request
References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
PR Checklist