Add cimwriter.dll and license to release artifacts - #39
Merged
Conversation
Assisted-by: GitHub-Copilot copilot-review Signed-off-by: Tingmao Wang <tingmaowang@microsoft.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions release workflow to include the CimWriter.dll binary and a corresponding license PDF in both the build artifacts and the draft GitHub Release assets.
Changes:
- Copy
CimWriter/LICENSE.pdfto a top-levelCimWriter.LICENSE.pdffor easier inclusion as a release asset. - Upload
CimWriter/CimWriter.dllandCimWriter.LICENSE.pdfalongside existingdmverity-vhdbinaries as build artifacts. - Attach the same additional files to the generated draft release.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KenGordon
approved these changes
Jul 1, 2026
KenGordon
left a comment
Contributor
There was a problem hiding this comment.
I guess we can't yet have tests as they depend on ws2025 05b runners. We should keep an eye out for those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: GitHub-Copilot copilot-review