Update output format and do a build check - #30
Conversation
| // Debug mode: warn but allow execution | ||
| log.WithFields(log.Fields{ | ||
| "current_build": build, | ||
| "required_build": 26100, |
There was a problem hiding this comment.
You need the more than this. 26100 => Windows 2025. There is a version number of WS2025 (today's one) that we require. Note that my Windows 11 25H2 is 26200.7985 and it is not suitable. I guess you need to check xxxxx.yyyy where xxxxx == 26100 and yyyy >= today's build.
| - `roothash` command outputs JSON with `layers` array and `mounted_cim` field | ||
|
|
||
| **Note:** Windows CIM creation requires the Windows cimwriter.dll. On Linux, you can use WSL2 with Windows interop enabled to run the `.exe` binary. But to get deterministic hashes on image repull, you need to use this tool on a WS2025 OS. | ||
| **Note:** Windows CIM creation requires the Windows CimWriter.dll. On Linux, you can use WSL2 to run the `.exe` binary. For deterministic hashes on image repull, you need to use this tool on Windows Server 2025 or later. |
There was a problem hiding this comment.
You need to specify the particular minimum WS2025
| tarballFlag = "tarball" | ||
| hashDeviceVhdFlag = "hash-dev-vhd" | ||
| dataVhdFlag = "data-vhd" | ||
| debugSkipVersionFlag = "debug-skip-version-check" |
There was a problem hiding this comment.
This is not entirely debug. We'll need it when using base2-hyp. Can I suggest "ignore-windows-version". There might also be a check in the hcsshim code BTW.
|
BTW this windows check is not critical path. I will approve the PR if you think it will take time to sort out. In particular you can't know the actual version to check until Monday most likely. |
|
Closing in favour of #31 |
2 participants
No description provided.