[internal/wclayer]: harden reset dir-state cleanup - #2788
Merged
Conversation
Address follow-up review feedback by making reset robust when currentIsDir is true while currentFile is nil. - Always clear currentIsDir in deferred cleanup (outside currentFile nil-check) - Guard the directory stream handling path with currentFile != nil - Add regression test for currentIsDir=true/currentFile=nil state Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
harden-currentisdir-reset
branch
from
June 23, 2026 05:07
8b2998c to
cc76a69
Compare
jterry75
approved these changes
Jun 23, 2026
rawahars
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address follow-up review feedback by making reset robust when currentIsDir is true while currentFile is nil.