Block cim create and mount check update - #2621
Merged
Merged
Conversation
pomahade
force-pushed
the
main
branch
2 times, most recently
from
March 5, 2026 00:32
98ed845 to
a5c3fad
Compare
Contributor
|
I think you'd need to rebase and drop other commits. |
Signed-off-by: Pooja Mahadev Soundalgekar <pomahade@microsoft.com>
anmaxvl
approved these changes
Mar 5, 2026
msscotb
reviewed
Mar 7, 2026
| // TODO(ambarve): Currently we are checking against a higher build number since there is no | ||
| // official build with block CIM support yet. Once we have that build, we should | ||
| // update the build number here. | ||
| return (build >= 27766 && cimfs.Supported()) || cimwriter.Supported() |
Contributor
There was a problem hiding this comment.
IsBlockCimSupported() || cimwriter.Supported()
msscotb
reviewed
Mar 7, 2026
| // IsBlockCimMountSupported returns true if block formatted CIMs (i.e block device CIM & | ||
| // single file CIM) are supported on the current OS build. | ||
| func IsBlockCimMountSupported() bool { | ||
| build := osversion.Build() |
Contributor
There was a problem hiding this comment.
func IsBlockCimMountSupported() bool {
IsBlockCimSupported()
}
|
|
||
| // IsVerifiedCimWriteSupported returns true if block CIM format supports also writing verification information in the CIM. | ||
| func IsVerifiedCimWriteSupported() bool { | ||
| build := osversion.Build() |
Contributor
There was a problem hiding this comment.
just IsBlockCimWriteSupported()
|
|
||
| // IsVerifiedCimMountSupported returns true if block CIM format supports mounting. | ||
| func IsVerifiedCimMountSupported() bool { | ||
| build := osversion.Build() |
Signed-off-by: Pooja Mahadev Soundalgekar <pomahade@microsoft.com>
helsaawy
approved these changes
Mar 9, 2026
msscotb
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new functions that adds cimwriter.dll check for block cim write/create and keeps block cim mount check to OS version and cimfs dll check.