switch to CimWriter.dll and regenerate syscalls - #2578
Merged
Conversation
Update CIMFS image creation syscalls to use CimWriter.dll. Signed-off-by: Maksim An <maksiman@microsoft.com>
helsaawy
approved these changes
Dec 22, 2025
helsaawy
left a comment
helsaawy
left a comment
Contributor
There was a problem hiding this comment.
Maybe not in this PR, but can we here:
func CimFsSupported() bool {
modcimfs.Load() == nil && modcimwriter.Load() == nil
}That way we can have in pkg\cimfs\cimfs.go:
func IsCimFSSupported() bool {
return (build >= osversion.V25H1Server || (build == osversion.V21H2Server && rv >= 2031)) && winapi.CimFsSupported()
}And avoid the test failures because the DLL isn't available?
Add `CimFsSupported` utility to check for CIM FS dlls. Update `pkg/cimfs/cimfs.go` to use `CimFsSupported` together with build number check. Signed-off-by: Maksim An <maksiman@microsoft.com>
msscotb
approved these changes
Dec 22, 2025
helsaawy
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CIMFS image creation syscalls to use CimWriter.dll.