C-WCOW: Unify data structures and reuse for C-LCOW and C-WCOW - #2544
Merged
Conversation
MahatiC
commented
Oct 28, 2025
Member
- This change repurposes existing data structures and uses them for both C-LCOW and C-WCOW
MahatiC
force-pushed
the
refactoring-confidential
branch
from
October 28, 2025 17:27
7f5ca46 to
fa8bfb1
Compare
KenGordon
reviewed
Oct 29, 2025
KenGordon
reviewed
Oct 29, 2025
MahatiC
force-pushed
the
refactoring-confidential
branch
from
October 29, 2025 10:23
fa8bfb1 to
8d14576
Compare
KenGordon
reviewed
Oct 29, 2025
ambarve
reviewed
Oct 29, 2025
ambarve
reviewed
Oct 29, 2025
MahatiC
force-pushed
the
refactoring-confidential
branch
3 times, most recently
from
October 31, 2025 16:17
990fe18 to
8cfcea8
Compare
MahatiC
force-pushed
the
refactoring-confidential
branch
3 times, most recently
from
November 5, 2025 11:47
5d6a794 to
309345c
Compare
MahatiC
marked this pull request as ready for review
November 6, 2025 09:03
KenGordon
reviewed
Nov 6, 2025
KenGordon
reviewed
Nov 6, 2025
MahatiC
force-pushed
the
refactoring-confidential
branch
from
November 6, 2025 14:20
309345c to
da9c178
Compare
MahatiC
force-pushed
the
refactoring-confidential
branch
from
November 21, 2025 11:33
da9c178 to
4057079
Compare
Member
Author
|
@anmaxvl Could you review this PR too? |
MahatiC
force-pushed
the
refactoring-confidential
branch
3 times, most recently
from
December 3, 2025 16:18
c4bfa1c to
9f69e49
Compare
anmaxvl
reviewed
Dec 5, 2025
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
MahatiC
force-pushed
the
refactoring-confidential
branch
from
December 11, 2025 13:46
9f69e49 to
0a5ffdf
Compare
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
MahatiC
force-pushed
the
refactoring-confidential
branch
from
December 11, 2025 13:49
0a5ffdf to
1bf838e
Compare
Contributor
|
@MahatiC , I think we should have something like this in the end:
|
MahatiC
force-pushed
the
refactoring-confidential
branch
from
December 16, 2025 15:33
2b56d28 to
b670bb1
Compare
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
MahatiC
force-pushed
the
refactoring-confidential
branch
from
December 16, 2025 16:01
b670bb1 to
948c16f
Compare
anmaxvl
approved these changes
Dec 17, 2025
Collaborator
|
@helsaawy can this be merged now? |
helsaawy
reviewed
Dec 22, 2025
helsaawy
left a comment
Contributor
There was a problem hiding this comment.
one comment, lgtm otherwise
helsaawy
approved these changes
Dec 22, 2025
helsaawy
left a comment
Contributor
There was a problem hiding this comment.
one comment, lgtm otherwise
anmaxvl
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.