Disable video console in SNP mode - #2528
Merged
Merged
Conversation
helsaawy
approved these changes
Sep 26, 2025
helsaawy
left a comment
helsaawy
left a comment
Contributor
There was a problem hiding this comment.
should we also add a check about EnableGraphicsConsole and SNP in "internal\uvm\create.go".verifyOptions?
ambarve
force-pushed
the
video_console_cwcow_fix
branch
from
September 28, 2025 13:40
1f31fdd to
bb8bd2f
Compare
Video console is not supported when a UVM is being started in SNP isolation mode. It is anyway always disabled when starting a pod, but uvmboot tool always enabled it until now. This change only enables it if the isolation mode isn't SNP. Also, adds a new log statement to log the generated UVM HCS doc. Signed-off-by: Amit Barve <ambarve@microsoft.com>
ambarve
force-pushed
the
video_console_cwcow_fix
branch
from
September 28, 2025 13:48
bb8bd2f to
66da492
Compare
helsaawy
approved these changes
Sep 29, 2025
anmaxvl
approved these changes
Sep 29, 2025
anmaxvl
left a comment
anmaxvl
left a comment
Contributor
There was a problem hiding this comment.
nit: in another PR, define a const maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video console is not supported when a UVM is being started in SNP isolation mode. It is anyway always disabled when starting a pod, but uvmboot tool always enabled it until now. This change only enables it if the isolation mode isn't SNP.
Also, adds a new log statement to log the generated UVM HCS doc.