Add annotation flag to uvmboot - #2521
Merged
Merged
Conversation
ambarve
reviewed
Sep 24, 2025
ambarve
reviewed
Sep 24, 2025
Allow specifying annotations for uVMs (currently LCOW only) to enable certain behavior instead of needing new flags for uVM creation options. Update `parseMounts` to log (instead of ignore) errors from parsing `mount` flag values. Add `trace` flag to enable trace (instead of just debug) level logs. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
uvmboot-annot
branch
from
September 25, 2025 15:18
36a3829 to
25611c9
Compare
ambarve
approved these changes
Sep 25, 2025
anmaxvl
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow specifying annotations for uVMs (currently LCOW only) to enable certain behavior instead of needing new flags for uVM creation options.
Update
parseMountsto log (instead of ignore) errors from parsingmountflag values.Add
traceflag to enable trace (instead of just debug) level logs.