Minor bug fixes for CWCOW - #2514
Merged
Merged
Conversation
ambarve
force-pushed
the
cwcow_bug_fixes
branch
2 times, most recently
from
September 10, 2025 14:28
fcacf6b to
8e0bf8c
Compare
1. uvmboot tool wasn't using absolute paths for the VHDs, this fixes it to use absolute paths. 2. Name of the VHD that contains the EFI partition for the confidential WCOW UVM was incorrectly changed to efi.vhd from boot.vhd. Revert that. 3. A new check was added for non base layer UtilityVM files during image pull. This scenario isn't supported but we shouldn't fail the entire image pull due to this. The image can be successfully pulled and used for a container even if it has utilityVM files in non-base layers. You just won't be able to use that image for running utilityVMs. In majority of the cases UtilityVM anyway uses the nanoserver image so this should be fine. 4. Initialize the mounted block CIMs tracking map. 5. Add a writable-efi flag to uvmboot to allow attaching EFI/boot VHD as read-only read-write 6. Fix incorrect UVM creation options type switch case. Signed-off-by: Amit Barve <ambarve@microsoft.com>
jterry75
approved these changes
Sep 11, 2025
ambarve
force-pushed
the
cwcow_bug_fixes
branch
from
September 12, 2025 12:03
8e0bf8c to
a0fe7d5
Compare
kiashok
approved these changes
Sep 12, 2025
micromaomao
reviewed
Oct 14, 2025
| case OptionsWCOW: | ||
| return opts.SecurityPolicyEnabled | ||
| case *OptionsLCOW: | ||
| case OptionsLCOW: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
There was a problem hiding this comment.
Sorry, nevermind, my main was old
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uvmboot tool wasn't using absolute paths for the VHDs, this fixes it to use absolute
paths.
Name of the VHD that contains the EFI partition for the confidential WCOW UVM was
incorrectly changed to efi.vhd from boot.vhd. Revert that.
A new check was added for non base layer UtilityVM files during image pull. This
scenario isn't supported but we shouldn't fail the entire image pull due to this. The
image can be successfully pulled and used for a container even if it has utilityVM files
in non-base layers. You just won't be able to use that image for running utilityVMs. In
majority of the cases UtilityVM anyway uses the nanoserver image so this should be fine.
Initialize the mounted block CIMs tracking map.
Add a writable-efi flag to uvmboot to allow attaching EFI/boot VHD as read-only
read-write
Fix incorrect UVM creation options type switch case.