add support for resource partitions - #2482
Merged
Merged
Conversation
anmaxvl
force-pushed
the
resource-partition-support
branch
from
July 17, 2025 03:53
62679ee to
1a715ac
Compare
helsaawy
reviewed
Jul 17, 2025
anmaxvl
force-pushed
the
resource-partition-support
branch
from
July 31, 2025 22:14
1a715ac to
d4847f8
Compare
jterry75
reviewed
Aug 1, 2025
jterry75
reviewed
Aug 1, 2025
jterry75
reviewed
Aug 1, 2025
jterry75
left a comment
jterry75
left a comment
Contributor
There was a problem hiding this comment.
Is this change in conflict with the use of others like the processor cpu group id or the memory job object names? Do we need to do an either or check? Left a few other comments.
Contributor
Author
good point. I don't think we allow setting memory job object names though. |
brian-young
reviewed
Aug 4, 2025
Adds annotation for resource partition id, when present, set the corresponding field on HCS doc (no-op for now), the rest will be handled by HCS. Signed-off-by: Maksim An <maksiman@microsoft.com>
Signed-off-by: Maksim An <maksiman@microsoft.com>
- better error messages - update doc strings - rename from pool to partition - add validation for resource partitions Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
resource-partition-support
branch
from
August 5, 2025 01:50
8e8df58 to
f6b9597
Compare
anmaxvl
changed the title
helsaawy
approved these changes
Aug 13, 2025
msscotb
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds annotation for resource partition id, when present, set the
corresponding field on HCS doc (no-op for now), the rest
will be handled by HCS.