guest/storage/scsi: Print log warning if GetDevicePath blocks due to wait - #2471
Merged
Conversation
micromaomao
force-pushed
the
tingmao/scsi-log
branch
from
July 16, 2025 15:44
b5e095b to
501fda1
Compare
Member
Author
|
No change rebase to main |
micromaomao
force-pushed
the
tingmao/scsi-log
branch
from
August 13, 2025 18:13
501fda1 to
99f78b2
Compare
helsaawy
approved these changes
Aug 13, 2025
jterry75
reviewed
Aug 14, 2025
| case <-ctx.Done(): | ||
| return "", ctx.Err() | ||
| default: | ||
| if !logged && logTime.Before(time.Now()) { |
Contributor
There was a problem hiding this comment.
Just a thought, why not <-time.After(time.Second * 5) as a case and then just continue. Yes you would get multiple log statements but it feels like thats ok. What if it takes 15 seconds? You would see multiple logs at 5 second intervals. But thats also helpful to see how long it is taking.
Member
Author
There was a problem hiding this comment.
that wouldn't work because we will restart the loop on default in 10ms, then the timer will restart, right?
micromaomao
force-pushed
the
tingmao/scsi-log
branch
from
September 2, 2025 13:03
99f78b2 to
b3bad0f
Compare
Member
Author
|
@anmaxvl Can you check what's going on? Both of my PRs seems to be stuck with this git error in CI |
…wait When there is a problem with SCSI devices, this makes it easy to see why the GCS is not responding to the message. Signed-off-by: Tingmao Wang <tingmaowang@microsoft.com>
micromaomao
force-pushed
the
tingmao/scsi-log
branch
from
September 15, 2025 14:43
b3bad0f to
875d2d4
Compare
ambarve
reviewed
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a problem with SCSI devices, this makes it easy to see why the GCS is not responding to the message. Otherwise one can only guess what's going on, which is not nice.
Example log line: