Move hcsshim/main to containerd v2.1.2 and update CIs to WS2025 - #2425
Merged
Conversation
kiashok
force-pushed
the
update-shim-ctrd2.0
branch
5 times, most recently
from
May 13, 2025 02:37
2adfd99 to
8b91059
Compare
kiashok
force-pushed
the
update-shim-ctrd2.0
branch
6 times, most recently
from
June 3, 2025 19:42
832e200 to
75dd87a
Compare
kiashok
force-pushed
the
update-shim-ctrd2.0
branch
5 times, most recently
from
June 4, 2025 22:31
cc93904 to
4836058
Compare
kiashok
force-pushed
the
update-shim-ctrd2.0
branch
from
June 12, 2025 16:38
4836058 to
ff0de5d
Compare
kiashok
changed the title
kiashok
marked this pull request as ready for review
June 12, 2025 16:39
kiashok
force-pushed
the
update-shim-ctrd2.0
branch
9 times, most recently
from
June 16, 2025 06:11
a99afdc to
aea85ca
Compare
kiashok
force-pushed
the
update-shim-ctrd2.0
branch
5 times, most recently
from
July 1, 2025 23:04
fab30fd to
7d62265
Compare
kiashok
force-pushed
the
update-shim-ctrd2.0
branch
from
July 2, 2025 17:17
7d62265 to
f3a3f7b
Compare
helsaawy
reviewed
Jul 2, 2025
kiashok
force-pushed
the
update-shim-ctrd2.0
branch
2 times, most recently
from
July 3, 2025 18:44
4c9d1c0 to
08451db
Compare
Contributor
Author
helsaawy
approved these changes
Jul 8, 2025
| return err | ||
| } | ||
| if err := shim.WriteAddress(filepath.Join(cwd, "address"), address); err != nil { | ||
| if err := writeAddress(filepath.Join(cwd, "address"), address); err != nil { |
Contributor
There was a problem hiding this comment.
we're ignoring the bootstrap.json file wholesale for now, right?
ambarve
approved these changes
Jul 9, 2025
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
kiashok
force-pushed
the
update-shim-ctrd2.0
branch
from
July 9, 2025 17:33
08451db to
0ae9c5d
Compare
helsaawy
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move hcsshim/main to containerd v2.1.2 and resolve dependencies.
Move CIs to WS2022 and WS2025.