[release-branch.go1.27] go: report removal of ms_nocgo_opensslcrypto - #2444
Open
George Adams (gdams) wants to merge 1 commit into
Open
[release-branch.go1.27] go: report removal of ms_nocgo_opensslcrypto#2444George Adams (gdams) wants to merge 1 commit into
George Adams (gdams) wants to merge 1 commit into
Conversation
Backport the retired experiment diagnostic to Go 1.27 so users get actionable guidance instead of an unknown GOEXPERIMENT error.
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Backports upstream PR #2443 to the Go 1.27 release branch by improving GOEXPERIMENT parsing diagnostics: instead of a generic unknown GOEXPERIMENT error, it returns a targeted migration message when the removed ms_nocgo_opensslcrypto experiment is present, and adds focused unit coverage in internal/buildcfg.
Changes:
- Add a specific
ParseGOEXPERIMENTerror forGOEXPERIMENT=ms_nocgo_opensslcrypto, explaining the Go 1.27 behavior. - Extend
internal/buildcfgtests to assert the new migration error text.
Patches are happy!
Show a summary per file
| File | Description |
|---|---|
| patches/0002-Add-crypto-backends.patch | Updates the backport patch to emit an actionable migration error for ms_nocgo_opensslcrypto and adds a corresponding internal/buildcfg test case. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2443 to Go 1.27.
Report an actionable error when
GOEXPERIMENT=ms_nocgo_opensslcryptois set, explaining that CGO-free system crypto is enabled automatically on supported platforms since Go 1.27. This avoids the genericunknown GOEXPERIMENTerror during upgrades.Testing: Not run, per request. Patch extraction and equivalence checks completed successfully;
git diff --checkpassed.