Skip to content

Increase code coverage#24

Open
nilay-kapadia wants to merge 26 commits intomainfrom
users/nilaykapadia/code-coverage
Open

Increase code coverage#24
nilay-kapadia wants to merge 26 commits intomainfrom
users/nilaykapadia/code-coverage

Conversation

@nilay-kapadia
Copy link

Increase low code coverage of the repository by:

  • Adding new test cases
  • Removing dead code
  • Adding new models to cover additional code

Closes #5

@nilay-kapadia nilay-kapadia added type:refactor Refactoring or improving of existing code version:minor labels Mar 2, 2023
@nilay-kapadia nilay-kapadia self-assigned this Mar 2, 2023
@jarz
Copy link
Member

jarz commented Mar 2, 2023

These four files need to be checked-in again with the correct line endings, when I run dotnet test locally they're modified.

  • test/Generator.Tests.Generated/Address.cs
  • test/Generator.Tests.Generated/AddressTestMap.cs
  • test/Generator.Tests.Generated/TestModel.cs
  • test/Generator.Tests.Generated/TestModelData.cs

@jarz
Copy link
Member

jarz commented Mar 3, 2023

We should also bump this number up: https://github.com/microsoft/dtdl-model-generator/blob/2fc93de6ed017d531945d5231f9eca5027481853/.github/workflows/build.yml#LL21C6-L21C28

@jarz jarz requested a review from a team as a code owner March 3, 2023 21:57
@jarz
Copy link
Member

jarz commented Mar 7, 2023

I had to use WSL to figure out the problem:

"Could not find a part of the path '/home/tim/dtdl-model-generator/test/Generator.Tests/bin/Debug/net6/TestDtdlErrorModels\\TestDtdlErrorUnsupportedContentType'."

Since Linux uses / (and the Build action runs on Linux) we just had to adjust the directory separator. Luckily, Windows can also treat / as a directory separator too.

@jarz jarz mentioned this pull request Mar 17, 2023
osamadawoood
osamadawoood previously approved these changes Apr 3, 2023
Copy link
Member

@jarz jarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final thing: can this line be updated to add CS0612 to the list? That will stop the obsolete warnings that are noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:refactor Refactoring or improving of existing code version:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase code coverage to 100%

3 participants