runtime: Add max buffer size to inetstack from the network runtime#1626
Merged
runtime: Add max buffer size to inetstack from the network runtime#1626
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds proper propagation of max buffer size configuration from the underlying physical layer (layer1) up through all network stack layers. The change ensures that configured buffer sizes (such as DPDK's max_body_size in Catnip) are properly used instead of relying on default implementations.
- Implements
max_buffer_size_bytes()method forDemiMemoryAllocatortrait across all network layers - Creates a chain of delegation from layer4 down to layer1 to retrieve the actual configured buffer size
- Fixes the issue where inetstack was not using the underlying physical layer's buffer size configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/inetstack/mod.rs | Implements max_buffer_size_bytes() for SharedInetStack, delegating to layer4 |
| src/inetstack/protocols/layer4/mod.rs | Implements max_buffer_size_bytes() for Peer, delegating to layer3 |
| src/inetstack/protocols/layer3/mod.rs | Implements max_buffer_size_bytes() for SharedLayer3Endpoint, delegating to layer2 |
| src/inetstack/protocols/layer2/mod.rs | Implements max_buffer_size_bytes() for SharedLayer2Endpoint, delegating to layer1 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
78b46e6 to
c1f4e07
Compare
Contributor
Author
|
Accidentally closed |
16a0493 to
3fc348e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the inetstack was using the default implementation of
max_buffer_size_bytes()rather than getting it from the underlying physical layer. For example, in Catnip, this meant that we were not using the configured DPDK max_body_size.