feat: implement getsockname() #72#1624
Closed
suryaprakash0010 wants to merge 1 commit intomicrosoft:devfrom
Closed
feat: implement getsockname() #72#1624suryaprakash0010 wants to merge 1 commit intomicrosoft:devfrom
suryaprakash0010 wants to merge 1 commit intomicrosoft:devfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
|
This looks good to me! Would you please add some tests to |
anandbonde
reviewed
Sep 26, 2025
| pub fn getsockname(&mut self) -> Result<SocketAddrV4, Fail> { | ||
| match self.local() { | ||
| Some(addr) => { | ||
| // We only support IPv4 addresses in demikernel |
Contributor
There was a problem hiding this comment.
This comment can be removed, the err msg makes it clear that we don't support IPv6.
Contributor
|
closing this PR as we haven't received any response from the author |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the missing
getsockname()function.Changes:
getsockname()to LibOS interfaceSharedNetworkQueueto retrieve local socket addressdemi_getsockname()C binding with validation, buffer checks, and error handlinggetpeername()implementationKey Points:
EINVAL,ENOTCONN,ENOTSUP)Fixes #72