Skip to content

Bump js-yaml from 4.3.0 to 4.3.2 in /scripts - #31

Open
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/scripts/js-yaml-4.3.2
Open

dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/scripts/js-yaml-4.3.2

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Bumps js-yaml from 4.3.0 to 4.3.2.

Changelog

Sourced from js-yaml's changelog.

4.3.2 - 2026-08-26

Changed

  • [backport] Hard-limit merge sequence size to 100.

Security

  • [backport] Count empty mappings in merge sequences toward maxTotalMergeKeys to limit CPU usage, #797.

4.3.1 - 2026-07-31

Security

  • [backport] Remove quadratic complexity from !!omap duplicate key detection.
Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 13, 2026
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.3.0 to 4.3.2.
- [Changelog](https://github.com/nodeca/js-yaml/blob/4.3.2/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.3.0...4.3.2)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.3.2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/scripts/js-yaml-4.3.2 branch from 1f14a20 to c63ac33 Compare September 17, 2026 16:17
Copilot AI lite review requested due to automatic review settings September 17, 2026 16:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The committed chat bundle does not include the dependency’s security fixes.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Bumps js-yaml from 4.3.0 to 4.3.2 to receive security fixes.

Changes:

  • Updates the declared dependency.
  • Refreshes the lockfile resolution and integrity metadata.
  • Critical (3 votes): Regenerate and commit scripts/chat-with-agent.bundle.js; it still contains the vulnerable implementation.
File summaries
File Description
scripts/package.json Updates js-yaml to 4.3.2.
scripts/package-lock.json Locks js-yaml at 4.3.2.
Review details

Files not reviewed (1)

  • scripts/package-lock.json: Generated file
  • Files reviewed: 1/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/package.json
"@opentelemetry/api": "^1.9.1",
"@opentelemetry/api-logs": "^0.220.0",
"js-yaml": "^4.3.0",
"js-yaml": "^4.3.2",
Copilot AI review requested due to automatic review settings September 18, 2026 19:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Regenerate and commit the runtime bundle so it includes the security fixes.

Review details

Files not reviewed (1)

  • scripts/package-lock.json: Generated file

Suppressed comments (1)

scripts/package.json:22

  • The dependency is bundled into the checked-in scripts/chat-with-agent.bundle.js, which is the entrypoint used by commands/chat.md, but that artifact still contains the pre-4.3.1 !!omap implementation (scripts/chat-with-agent.bundle.js:871-895) and the old merge limits. As a result, the shipped/runtime script does not receive the security fixes advertised by this bump. Please regenerate and commit the bundle (the source import at scripts/src/chat-with-agent.js:39 will pick up 4.3.2).
    "js-yaml": "^4.3.2",
  • Files reviewed: 1/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants