Fix crash when disposing DAC after self-attach on Linux (#1282)#1361
Open
leculver wants to merge 2 commits intomicrosoft:mainfrom
Open
Fix crash when disposing DAC after self-attach on Linux (#1282)#1361leculver wants to merge 2 commits intomicrosoft:mainfrom
leculver wants to merge 2 commits intomicrosoft:mainfrom
Conversation
On non-Windows platforms, calling dlclose on the DAC library (libmscordaccore.so) after inspecting the current process crashes the CLR. The DAC shares internal state with the running CLR, and unloading it corrupts that state, causing a SIGSEGV in libcoreclr.so. This fix suppresses FreeLibrary on the DAC when the target process matches the current process ID on non-Windows platforms.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Linux/macOS self-attach crash caused by unloading the DAC native library (dlclose/FreeLibrary) after CreateRuntime, by allowing DAC unloading to be suppressed when the target PID is the current process.
Changes:
- Added an option to suppress
FreeLibraryinRefCountedFreeLibrary. - Updated
DacLibraryto suppress unloading the DAC on non-Windows platforms when inspecting the current process.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Microsoft.Diagnostics.Runtime/RefCountedFreeLibrary.cs | Adds a suppression flag to prevent unloading the native library on final Release. |
| src/Microsoft.Diagnostics.Runtime/DacLibrary.cs | Detects non-Windows self-attach and uses the new suppression flag to avoid dlclose of the DAC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On non-Windows platforms, calling dlclose on the DAC library (libmscordaccore.so) after inspecting the current process crashes the CLR. The DAC shares internal state with the running CLR, and unloading it corrupts that state, causing a SIGSEGV in libcoreclr.so.
This fix suppresses FreeLibrary on the DAC when the target process matches the current process ID on non-Windows platforms.
Fixes #1282