Fix IndexOutOfRangeException in PEImage.DoRead relocation handling#1360
Merged
leculver merged 1 commit intomicrosoft:mainfrom Feb 18, 2026
Merged
Fix IndexOutOfRangeException in PEImage.DoRead relocation handling#1360leculver merged 1 commit intomicrosoft:mainfrom
leculver merged 1 commit intomicrosoft:mainfrom
Conversation
Fix bug where negative BinarySearch results were used as array indices instead of their bitwise complements in DoRead's relocation handling. beginSearch Case 3: beginRelocation = beginSearch - 1 -> beginSearchComplement - 1 endSearch Case 3: endRelocation = endSearch -> endSearchComplement Fixes microsoft#1288
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in ClrMD’s PE image reader (PEImage.DoRead) when applying relocations by correctly handling negative Array.BinarySearch results (using the bitwise complement insertion index instead of the negative return value). This aligns with the reported IndexOutOfRangeException in issue #1288 and improves robustness when reading PE data from partial/virtualized sources (e.g., dumps produced by dotnet-monitor).
Changes:
- Corrected relocation start index calculation when the read begins inside a relocation (use
beginSearchComplement - 1). - Corrected relocation end index calculation when the read ends inside a relocation (use
endSearchComplement). - Updated related
Debug.Assertchecks to validate the corrected indices.
steveisok
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug where negative BinarySearch results were used as array indices instead of their bitwise complements in DoRead's relocation handling.
beginSearch Case 3: beginRelocation = beginSearch - 1 -> beginSearchComplement - 1
endSearch Case 3: endRelocation = endSearch -> endSearchComplement
Fixes #1288