Add a kola test asserting the SPDX package manifests ship in the image

[Vince Perri (vinceaperri)]

Summary

Adds acl.packages.package-manifest, which checks that /usr/share/os-manifests contains at least one *.spdx.json and that one of them is for the image, package-manifest.spdx.json. Sysext manifests are counted but not required.

Presence is all this checks. The documents' contents are compared against a checked-in golden SPDX 2.2 document by build_library/rpm/tests/test_generate_package_manifest.sh in azure-container-linux, run as a step in the Build RPMs job of the ACL GitHub PR pipeline.

Change Log

• Add kola/tests/packages/package_manifest.go which registers acl.packages.package-manifest.

Type of Change

• New kola test
• Kola test fix/update
• Platform integration change (Azure, QEMU, etc.)
• CLI/command change
• CI/automation change
• Bug fix
• Documentation update

Merge order

1. Merge this PR.
2. Wait for a mantle LKG container carrying it to be published to ACR.
3. Merge azure-container-linux#57. It is what adds generate_package_manifest.py to acl-scripts.
4. Merge acl-pipelines !28911 last.

Test Methodology

• Full build for acldevel 1192360.

Merge Checklist

• go build ./... passes (basic validation)
• docker build -t mantle . succeeds (full multi-arch build; required for build-affecting changes)
• go test ./... passes
• go vet ./... reports no issues
• Relevant kola tests pass against a test image
• Documentation has been updated to match any changes
• Ready to merge

[Copilot]

Pull request overview

Adds a new kola test to verify that Azure Container Linux images include SPDX package manifest(s) under /usr/share/os-manifests, and that the base image’s package-manifest.spdx.json is present.

Changes:

• Register a new kola test packages.package-manifest (ACL-only) for qemu, qemu-unpriv, and azure.
• Implement the test logic to discover *.spdx.json files in /usr/share/os-manifests and assert the image manifest exists.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

kola/tests/packages/package_manifest.go:27

• Test names in this repo use a distro prefix (e.g., acl. / cl.). Since this test is restricted to acl only, naming it without the prefix makes it inconsistent with existing ACL-only tests and can make selection/filtering less clear.

		Name:        "packages.package-manifest",

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

kola/tests/packages/package_manifest.go:31

• The PR description/changelog refers to the test as packages.package-manifest, but the code registers it as acl.packages.package-manifest. Since acl-only tests elsewhere consistently use the acl. prefix (e.g., kola/tests/misc/kdump.go:26, kola/tests/ignition/passwd.go:147), please align the PR description (or rename the test) so users can reliably discover/run it by name.

	register.Register(&register.Test{
		Run:         packageManifestTest,
		ClusterSize: 1,
		Name:        "acl.packages.package-manifest",
		// Written by write_package_manifest in azure-container-linux, so
		// upstream Container Linux images do not carry these files.
		Distros:   []string{"acl"},
		Platforms: []string{"qemu", "qemu-unpriv", "azure"},

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

kola/tests/packages/package_manifest.go:49

• If /usr/share/os-manifests is missing, the current find call will fail via MustSSH, but the fatal message won’t include stderr (where find reports the missing directory). Adding an explicit directory existence check makes the failure clearer, and quoting the path in the find command makes it more robust if the constant ever changes.

	findCmd := fmt.Sprintf("find %s -maxdepth 1 -type f -size +0c -name '*.spdx.json'", manifestDir)
	out := c.MustSSH(m, findCmd)

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[SeanDougherty]

LGTM