Skip to content

Refactor TelemetryHelper credential handling #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
v-gonett wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

Refactor TelemetryHelper credential handling #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...ce/dotnet/DevTools/Core/Approvals.SupportServices.Helper/ServiceHelper/TelemetryHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ public TelemetryHelper(ConfigurationHelper configurationHelper,
_environment = actionContextAccessor?.ActionContext?.RouteData?.Values["env"]?.ToString();
_configurationHelper = configurationHelper;
_httpHelper = httpHelper;
_tokenCredential = tokenCredential ?? new DefaultAzureCredential();
#if DEBUG
_tokenCredential = tokenCredential ?? new DefaultAzureCredential(); // CodeQL [SM05137] Suppress CodeQL issue since we only use DefaultAzureCredential in development environments.
#else
_tokenCredential = tokenCredential ?? new ManagedIdentityCredential();
#endif
}

/// <summary>
Expand Down Expand Up @@ -124,4 +128,4 @@ private void MergeAIScopeResponse(ref JObject response, JObject responseData)
rows.Add(row);
}
}
}
}