Repository navigation
Center tag group counts over the state dot column - #21996
Closed
Maddy Montaquila (maddymontaquila) wants to merge 1 commit into
Closed
Maddy Montaquila (maddymontaquila) wants to merge 1 commit into
Maddy Montaquila (maddymontaquila) wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Maddy Montaquila (maddymontaquila)
requested review from
James Newton-King (JamesNK) and
Adam Ratzman (adamint)
as code owners
November 10, 2026 01:15
Member
|
Maddy Montaquila (@maddymontaquila) and Sébastien Ros (@sebastienros) looks like this one was missed? |
Adam Ratzman (adamint)
approved these changes
Nov 11, 2026
Adam Ratzman (adamint)
left a comment
Adam Ratzman (adamint)
left a comment
Member
There was a problem hiding this comment.
Looks good. I verified the compact split-pane alignment at both target widths, and the full-canvas and touch exclusions behave as intended.
Maddy Montaquila (maddymontaquila)
pushed a commit
that referenced
this pull request
Nov 13, 2026
In the compact sidebar at rest, the rows' state dots form a column at the end of the list. The group header's chevron sat 13px past it, so center it over that column. Replaces #21996. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
Maddy Montaquila (maddymontaquila)
added a commit
that referenced
this pull request
Nov 13, 2026
…s, trace log previews, test flakes (#22232) The remaining dashboard work for `release/17.0`, as one squashable PR: one commit per change, in this order. **Backported from `main` (cherry-picked with `-x`):** 1. #21500: Fix flaky terminal WebSocket close handshake abort (test only) 2. #21503: Fix bUnit JS timeout flakes in StructuredLogs/Traces/TraceDetails tests (test only) 3. #21471: Fix flaky TerminalWebSocketTests final-output drain (test only) 4. #21924: Read resource row state at every density in dashboard browser tests (test only) 5. #22142: Fix inconsistent dashboard action icon colors. It conflicted with #22188 in `ResourcesLayout.razor`: the resolution keeps the row menu on every row, parameters included, with #22142's icon color. **From open PRs against `main`, applied as they stand:** 6. #22228: Fix resource sidebar hover state after selection 7. #22229: Keep resource picker popup width consistent **New:** 8. Render the trace log preview only for the marker that's hovered or focused. Each log marker rendered its own hidden preview for the tooltip, so a span with many logs built over a million hidden elements. The page now renders one preview, filled on hover or focus. This addresses Copilot's review on #22230. 9. Center tag group chevrons over the state dot column. In the compact sidebar at rest, the rows' state dots form a column at the end of the list, and the group header's chevron sat 13px past it. This replaces #21996. 10. Fix two resource pane Playwright tests: - `Rows_KeepDensity` expected parameter rows in the expanded list to have no overflow menu, but every row has one now. - `FilterAndGrouping` could hover before the feedback prompt pushed the page down 40px, leaving the pointer on the brand. It now waits for the prompt. When `release/17.0` merges back into `main`, the `Rows_KeepDensity` change has to come along with it, because #22228's version of that test expects no menu on parameter rows. Once this is in `release/17.0`, `release/17.0` merges back into `main`. #22228 and #22229 can then close on `main`. ## Customer Impact Fixes and polish to the 17.0 dashboard: icon colors, the resource sidebar and picker, and trace pages with many logs. ## Testing - `Aspire.Dashboard.Components.Tests`: 1,447 passed, 0 failed. - `ResourcePaneResponsiveTests.FilterAndGrouping_*` and `Rows_KeepDensity*`: 11 passed. `FilterAndGrouping` passed 5 runs in a row after the fix; before it, the 2000px cases failed in about half the runs. - The chevron alignment was checked in the browser at 1440px: the chevron and the dots are both centered 25px from the list's end. ## Risk Low. Dashboard-only, and the backports are unchanged apart from the one conflict described above. ## Regression? No. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: David Fowler <davidfowl@gmail.com> Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Maddy Montaquila <maddy@MadBook-Pro-20.local> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: James Newton-King <james@newtonking.com> Co-authored-by: Sébastien Ros <1165805+sebastienros@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the sidebar groups resources by tag, each group's count badge sat 9px to the right of the state dots of the rows below it, so the two didn't read as one column.
The header and its rows end differently:
Compact sidebar rows now give the badge a 9px end margin, so single-digit badges are centered on the dot column. The fix only applies where rows can be hovered. On touch screens the action rail is always showing, and the full canvas lays its rows out as a table.
This is stacked on #21943 and targets its branch.
Validation
Aspire.Dashboard.Components.Testspass: 1400 of 1400.🤖 Generated with Claude Code