Repository navigation
Harden Integration Data Updater and alert on failure - #2046
Closed
David Pine (IEvangelist) wants to merge 2 commits into
Closed
David Pine (IEvangelist) wants to merge 2 commits into
David Pine (IEvangelist) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Folded into #1961. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The failure reporter shares the updater’s 45-minute job timeout, so a timed-out scheduled run can terminate before reporting and produce no alert.
1 open issue
What changed in this PR
This PR fixes optional catalog-field handling in the Integration Data Updater and adds issue-based alerts for scheduled failures, addressing the failure described in #1960.
Changes:
- Read optional
apiReference,title, andversionfields safely under PowerShell StrictMode. - Preserve entries with omitted or true
apiReference; exclude explicit false values. - Create or comment on a tracking issue when a scheduled update fails.
| File | Description |
|---|---|
src/tools/PackageJsonGenerator/generate-package-json.ps1 |
Safely handles optional catalog properties under StrictMode. |
.github/workflows/update-integration-data.yml |
Adds failure reporting and issue-write permission. |
Review effort: Balanced
Comment on lines
+181
to
+182
| - name: Report failure | ||
| if: ${{ failure() && github.event_name == 'schedule' }} |
Contributor
Frontend HTML artifact readyThe latest frontend build uploaded the This comment updates automatically when a new frontend build artifact is uploaded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #1960 and #1961. The Integration Data Updater has failed daily since #1895 without anyone noticing.
apiReference,title,version) viaPSObject.Propertiesingenerate-package-json.ps1soSet-StrictMode -Version Latestno longer throws on missing properties. OmittedapiReferenceis included; only explicitfalseis excluded.update-integration-data.yml: on a failed scheduled run it opens (or comments on) a single "Integration Data Updater is failing" issue. The job getsissues: writefor this.This overlaps with the predicate change in #1961, so one of the two will need a rebase.
Third-party links and affiliations
None.
Validation
generate-package-json.ps1: 0 errors.workflow_dispatch/scheduled run (the alert step only fires on scheduled failures).