Skip to content

ci: add a non-blocking Windows test job (closes #3884) - #3896

Open
Dipak Chaudhari (dchaudhari7177) wants to merge 1 commit into
microsoft:mainfrom
dchaudhari7177:ci/3884-windows-test-job
Open

ci: add a non-blocking Windows test job (closes #3884)#3896
Dipak Chaudhari (dchaudhari7177) wants to merge 1 commit into
microsoft:mainfrom
dchaudhari7177:ci/3884-windows-test-job

Conversation

@dchaudhari7177

Copy link
Copy Markdown

Closes #3884, taking the "suggested minimal step" from the issue.

Confirmed on current main

$ grep -h -oE "runs-on:.*" .github/workflows/*.yml | sort | uniq -c
      1 runs-on: ${{ matrix.os }}
      1 runs-on: ubuntu-24.04
     98 runs-on: ubuntu-latest

$ grep -riE "windows" .github/workflows/
.github/workflows/publish.yml:  - { os: windows-2022, platform: windows-x86_64, ... }

$ grep -c "runs-on" .github/workflows/ci.yml
19

One Windows runner in the repository, and it builds the win_amd64 wheel without running the suite on it. ci.yml -- the file #310's acceptance criteria named -- has no windows and no macos.

What this adds

A test-windows job that reports and cannot gate:

  • continue-on-error: true
  • not in ci-complete's needs list, so it is invisible to the merge gate rather than merely tolerated by it

Both are deliberate. The suite has never run on Windows, so the first run is a measurement, not a pass/fail. Promote the job once its failures are triaged.

Scope, and what is left out

Nine packages -- the ones needing neither OPA nor the native ACS Rust SDK:

agent-mesh, agent-hypervisor, agent-sre, agent-runtime, agent-lightning,
agent-primitives, agent-mcp-governance, agent-discovery, agent-rag-governance

The five ACS-backed packages (agent-os, agt-policies, agent-compliance, agent-marketplace, agent-sandbox) are excluded: they need a Windows OPA binary and a maturin build on Windows, each its own piece of work, and putting them in the first run would bury the pure-Python signal this job exists for.

One Python version (3.13) rather than the Linux job's four, since a Windows runner costs about twice a Linux one and this is a smoke signal.

Keeping it from drifting

Steps default to shell: bash, which windows-latest ships via Git for Windows, so the change-gate and install logic is the same shell as the Linux test job rather than a second PowerShell transcription that would drift from it. Actions use the same pinned SHAs already in this file.

Validation

$ python -c "yaml.safe_load(...)"          # parses; 20 jobs
  test-windows present:      True
  continue-on-error:         True
  runs-on:                   windows-latest
  in ci-complete needs:      False
  matrix packages:           9

$ actionlint .github/workflows/ci.yml      # rhysd/actionlint container
  1 finding, with this job and on main alike (a pre-existing SC2193 at
  build-pypi, line 509, untouched here)

I cannot run a GitHub Windows runner locally, so what the first run reports is genuinely unknown -- that is the point of the job, and the reason it is non-blocking. If you would rather start with a single package, or on a schedule only rather than on pull requests, say which and I will narrow it.

Every test job in .github/workflows runs on Linux: 98 ubuntu-latest, one
ubuntu-24.04, one matrix.os. The only Windows runner in the repository is
in publish.yml, where it builds the win_amd64 wheel and does not test it.
ci.yml, the file microsoft#310's acceptance criteria named, has 19 jobs and no
occurrence of windows or macos.

That matters here more than for an ordinary library: the package documents
Python 3.9+ on any platform, ships scripts/quickstart.ps1 as the Windows
install path, and publishes the wheel. microsoft#3831 is the shape of what gets
through, a governance hook that silently never fires and leaves an audit
log that reads as no violations.

This measures the gap rather than enforcing it. The job carries
continue-on-error and is absent from ci-complete's needs list, so it
reports and cannot block a merge. Promote it once its failures are
triaged.

Scope kept small on purpose: the nine packages that need neither OPA nor
the native ACS Rust SDK, one Python version. A Windows OPA binary and a
maturin build on Windows are each their own piece of work, and adding
them here would bury the pure-Python signal. Steps default to bash, which
windows-latest ships, so the gate and install logic stays one copy rather
than drifting from the Linux job.
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions github-actions Bot added scripts/ci/cd size/M Medium PR (< 200 lines) labels Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

PR Review Summary

Check Status Details
🔍 Code Review ⚠️ Missing No current-run comment
🛡️ Security Scan ⚠️ Missing No current-run comment
🔄 Breaking Changes ⚠️ Missing No current-run comment
📝 Docs Sync ⚠️ Missing No current-run comment
🧪 Test Coverage ⚠️ Missing No current-run comment

Verdict: ⚠️ AI review incomplete; ready for human review

AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

🟡 Contributor Check: MEDIUM

Check Result
Profile MEDIUM
Credential LOW
Overall MEDIUM

Automated check by AGT Contributor Check.

@github-actions github-actions Bot added the needs-review:MEDIUM Contributor check flagged MEDIUM risk label Sep 7, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown

Dipak Chaudhari (@dchaudhari7177) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review:MEDIUM Contributor check flagged MEDIUM risk scripts/ci/cd size/M Medium PR (< 200 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#310 was closed as completed, but no Windows test job exists in .github/workflows

1 participant