-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Python: preserve multimodal messages in AG-UI chat client requests #8116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CoralGarden52
wants to merge
6
commits into
microsoft:main
Choose a base branch
from
CoralGarden52:fix/ag-ui-multimodal-input-8114
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
03cb0f9
fix(ag-ui): preserve multimodal input messages
CoralGarden52 c4ebeef
fix(ag-ui): preserve non-base64 data URIs
CoralGarden52 4a0bb02
fix(ag-ui): preserve mixed JSON attachments
CoralGarden52 e562c95
fix(ag-ui): require explicit state carrier
CoralGarden52 fd3bdf7
fix(ag-ui): preserve historical and legacy state carriers
CoralGarden52 47efb6e
fix(ag-ui): keep mixed messages out of legacy state fallback
CoralGarden52 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up on the earlier mixed-JSON fix: could legacy extraction keep the dedicated state-only boundary? With
allow_legacy_state_carrier=True,_extract_legacy_json_state()accepts JSON inside a final text-plus-document message, thenmessages_to_send.pop()drops the entire prompt and sends the document asstate. Could the fallback require exactly one unmarked JSON content so opting into migration does not reintroduce the message loss fixed earlier?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Evan Mattson (@moonbox3) I’ve addressed this in a follow-up. The legacy fallback now requires the final message to contain exactly one unmarked
application/jsoncontent, so mixed text-plus-document messages remain intact and are sent through the AG-UI converter. The single-content legacy convention remains available withallow_legacy_state_carrier=True, including the deprecation warning. A request-level regression test covers the mixed-message case.