-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Python: fix: preserve parallel function_result contents in AG-UI conversion #7980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Eduard van Valkenburg (eavanvalkenburg)
merged 4 commits into
microsoft:main
from
manjunathshiva:python-agui-parallel-function-results-7979
Sep 1, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3a168cd
Python: fix: preserve parallel function_result contents in AG-UI conv…
manjunathshiva e60e27d
Python: fix: preserve non-result contents in mixed AG-UI tool messages
manjunathshiva dd3f093
Python: fix: use independent ids for split AG-UI tool messages
manjunathshiva 508d879
Merge branch 'main' into python-agui-parallel-function-results-7979
manjunathshiva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a follow up here...
Could we preserve the original call/result order when splitting mixed messages? This loop emits every
function_resultbefore the separate message containingtool_calls, so a framework-produced [function_call,function_result] message round-trips as [function_result,function_call]. Providers require a tool result to follow its matching assistant call, soAGUIChatClientcan send an orphan result that is rejected or dropped while the later call remains pending. Walkingmsg.contentsand flushing assistant call/text segments before each result would preserve parallel results without reversing the transcript.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, thanks for the careful follow-up. Emitting the results before the
tool_callssegment reverses a[function_call, function_result]message into[function_result, function_call], which orphans the result against its call. Walkingmsg.contentsin order and flushing any accumulated assistant call/text segment before eachfunction_resultpreserves the original call→result ordering, keeps parallel results intact, and keeps trailing assistant text after the results. I'll open a follow-up PR with that change plus a regression test for the[function_call, function_result]round-trip, and link it here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened the follow-up: #8005. It walks
msg.contentsin order and flushes the assistant call/text segment before eachfunction_result, so[function_call, function_result]now emits as[assistant(call), tool(result)]instead of reversing. Added regression tests for the ordering plus the parallel-result and trailing-text cases from #7980.