Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/CODING_STANDARD.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Public modules must include a module-level docstring, including `__init__.py` fi

## Type Annotations

We use typing as a helper, it is not a goal in and of itself, so be pragmatic about where and when to strictly type, versus when to use a targetted cast or ignore.
We use typing as a helper, it is not a goal in and of itself, so be pragmatic about where and when to strictly type, versus when to use a targeted cast or ignore.
In general, the public interfaces of our classes, are important to get right, internally it is okay to have loosely typed code, as long as tests cover the code itself.
This includes making a conscious choice when to program defensively, you can always do `getattr(item, 'attribute')` but that might end up causing you issues down the road
because the type of `item` in this case, should have that attribute and if it doesn't it points to a larger issue, so if the type is expected to have that attribute, you should
Expand Down
2 changes: 1 addition & 1 deletion python/DEV_SETUP.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ uv run poe install
uv run poe prek-install
```

Alternatively, you can reinstall the venv, pacakges, dependencies and prek hooks with a single command (but this requires poe in the current env), this is especially useful if you want to switch python versions:
Alternatively, you can reinstall the venv, packages, dependencies and prek hooks with a single command (but this requires poe in the current env), this is especially useful if you want to switch python versions:

```bash
uv run poe setup -p 3.13
Expand Down
2 changes: 1 addition & 1 deletion python/packages/ollama/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ pip install agent-framework-ollama --pre

and see the [README](https://github.com/microsoft/agent-framework/tree/main/python/README.md) for more information.

# Run samples with the Ollama Conector
# Run samples with the Ollama Connector

You can find samples how to run the connector in the [Ollama provider samples](../../samples/02-agents/providers/ollama).
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

user input -> Agent A -> Agent B -> Agent C -> Agent A -> ... -> output

Depending of wether request info is enabled, the flow may include user input (except when an agent hands off):
Depending on whether request info is enabled, the flow may include user input (except when an agent hands off):

user input -> [Agent A -> Request info] -> [Agent B -> Request info] -> [Agent C -> ... -> output

Expand Down
Loading