Skip to content

Python: Update hash algorithm in workspace_poe_tasks.py - #6802

Merged
SergeyMenshykh merged 1 commit into
microsoft:mainfrom
SergeyMenshykh:sergeymenshykh-fix-sha1-to-sha256-sdl-compliance
Jun 29, 2026
Merged

Python: Update hash algorithm in workspace_poe_tasks.py#6802
SergeyMenshykh merged 1 commit into
microsoft:mainfrom
SergeyMenshykh:sergeymenshykh-fix-sha1-to-sha256-sdl-compliance

Conversation

@SergeyMenshykh

Copy link
Copy Markdown
Contributor

Update hash algorithm used for cache key generation in workspace_poe_tasks.py.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 29, 2026 15:36
@moonbox3 Evan Mattson (moonbox3) added the python Usage: [Issues, PRs], Target: Python label Jun 29, 2026
@github-actions github-actions Bot changed the title Update hash algorithm in workspace_poe_tasks.py Python: Update hash algorithm in workspace_poe_tasks.py Jun 29, 2026
@SergeyMenshykh SergeyMenshykh self-assigned this Jun 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the hashing algorithm used to derive per-invocation mypy cache directory keys in workspace_poe_tasks.py, helping avoid use of sha1 while keeping deterministic cache partitioning for concurrent mypy runs.

Changes:

  • Switch mypy cache key generation from hashlib.sha1 to hashlib.sha256 (still truncated to 16 hex chars) for isolated .mypy_cache directories.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Code Review

Reviewers: 5 | Confidence: 94% | Result: All clear

Reviewed: Correctness, Security Reliability, Test Coverage, Failure Modes, Design Approach


Automated review by SergeyMenshykh's agents

@SergeyMenshykh
SergeyMenshykh enabled auto-merge June 29, 2026 15:42
@SergeyMenshykh
SergeyMenshykh added this pull request to the merge queue Jun 29, 2026
Merged via the queue into microsoft:main with commit 07ddabb Jun 29, 2026
41 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in Agent Framework Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Usage: [Issues, PRs], Target: Python

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants