Skip to content

Python: Accept SSE data lines without a space in the AG-UI client #10249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ni (nniiovoo) wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −2
Open

Python: Accept SSE data lines without a space in the AG-UI client #10249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions python/packages/ag-ui/agent_framework_ag_ui/_http_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,11 @@ async def exit_response(

async for line in response.aiter_lines():
# Parse Server-Sent Events format
if line.startswith("data: "):
data = line[6:] # Remove "data: " prefix
if line.startswith("data:"):
data = line[5:]
# The space after "data:" is optional in SSE.
if data.startswith(" "):
data = data[1:]
try:
event = json.loads(data)
logger.debug(f"Received event: {event.get('type', 'UNKNOWN')}")
Expand Down
14 changes: 14 additions & 0 deletions python/packages/ag-ui/tests/ag_ui/test_http_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,20 @@ async def mock_aiter_lines():
assert events[0]["type"] == "RUN_FINISHED"


async def test_post_run_accepts_data_lines_without_space(sample_events):
"""The space after "data:" is optional in SSE, so "data:{...}" lines must be parsed too."""
body = "".join(f"data:{json.dumps(event)}\n\n" for event in sample_events)

def handler(request: httpx.Request) -> httpx.Response:
return httpx.Response(200, headers={"content-type": "text/event-stream"}, text=body)

async with httpx.AsyncClient(transport=httpx.MockTransport(handler)) as client:
service = AGUIHttpService("http://localhost:8888/", http_client=client)
events = [event async for event in service.post_run(thread_id="thread_123", run_id="run_456", messages=[])]

assert events == sample_events


async def test_context_manager():
"""Test context manager functionality."""
async with AGUIHttpService("http://localhost:8888/") as service:
Expand Down
Loading