Repository navigation
.NET: [BREAKING] Support scoped and transient agent lifetimes in Foundry Hosting #10238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Roger Barreto (rogerbarreto)
wants to merge
4
commits into
microsoft:main
Choose a base branch
from
rogerbarreto:foundry-agent-di-lifetimes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,819
−90
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3f6d66d
.NET: Support scoped and transient agent lifetimes in Foundry Hosting
rogerbarreto 2587519
Address review feedback on Foundry agent lifetimes
rogerbarreto 94f66ee
.NET: Register Foundry session stores separately from agents
rogerbarreto 8e316de
Document how Foundry agents choose their session store
rogerbarreto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
dotnet/src/Microsoft.Agents.AI.Foundry.Hosting/FoundryDefaultAgentName.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // Copyright (c) Microsoft. All rights reserved. | ||
|
|
||
| using Microsoft.Shared.Diagnostics; | ||
|
|
||
| namespace Microsoft.Agents.AI.Foundry.Hosting; | ||
|
|
||
| /// <summary> | ||
| /// The name of the agent registered through the factory overload of <c>AddFoundryResponses</c> that answers | ||
| /// requests without a matching agent name. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// <para> | ||
| /// The factory overload registers its agent only under the agent name. It does not add a non-keyed | ||
| /// registration that forwards to the keyed one, because Microsoft DI disposes the object a factory returns | ||
| /// once per registration that created or returned it, so a forwarding registration would dispose the same | ||
| /// object twice. This value is registered instead, only when no default agent existed at registration time, | ||
| /// so the response handler can route requests without an agent name to that agent. | ||
| /// </para> | ||
| /// <para> | ||
| /// The response handler ignores it when an <see cref="AIAgent"/> is registered without a key, because that | ||
| /// agent receives requests without an agent name. Sessions of the agent named here are stored in the location | ||
| /// <c>AddFoundryResponses(agent)</c> uses for the default agent, <c>name:{Name}</c>, whatever its lifetime. | ||
| /// </para> | ||
| /// </remarks> | ||
| internal sealed class FoundryDefaultAgentName | ||
| { | ||
| public FoundryDefaultAgentName(string name) | ||
| { | ||
| this.Name = Throw.IfNullOrWhitespace(name); | ||
| } | ||
|
|
||
| /// <summary>Gets the key the default factory agent is registered under.</summary> | ||
| public string Name { get; } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolving the non-keyed default before checking the requested key means every named request constructs that unrelated agent too. If its transient/scoped factory throws or performs expensive side effects, a healthy keyed agent can no longer serve its own requests. Resolve the keyed target first and avoid instantiating the non-keyed default unless it is actually selected, while preserving storage identity through registration metadata.