Skip to content

Python: chore(core): remove unused URI_PATTERN and correct add_chain cycle docstring #10105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into from
Nov 6, 2026
Merged

Python: chore(core): remove unused URI_PATTERN and correct add_chain cycle docstring #10105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions python/packages/core/agent_framework/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,8 +424,6 @@ def _restore_compaction_annotation_in_additional_properties(

CreatedAtT = str # Use a datetimeoffset type? Or a more specific type like datetime.datetime?

URI_PATTERN = re.compile(r"^data:(?P<media_type>[^;]+);base64,(?P<base64_data>[A-Za-z0-9+/=]+)$")

KNOWN_MEDIA_TYPES = [
"application/json",
"application/octet-stream",
Expand Down
6 changes: 5 additions & 1 deletion python/packages/core/agent_framework/_workflows/_workflow_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,11 @@ def add_chain(self, executors: Sequence[Executor | SupportsAgentRun]) -> Self:
The output of each executor in the chain will be sent to the next executor in the chain.
The input types of each executor must be compatible with the output types of the previous executor.

Cycles in the chain are not allowed, meaning an executor cannot appear more than once in the chain.
An edge is added between each consecutive pair of executors in the sequence. If an executor
appears more than once, the corresponding edges are still added, which can introduce a cycle
(for example, ``add_chain([a, b, a])`` adds the edges ``a -> b`` and ``b -> a``). This is
permitted: the workflow graph supports cycles, just as calling ``add_edge(a, b)`` followed by
``add_edge(b, a)`` does.

Args:
executors: A list of executors or agents to chain together.
Expand Down
Loading