Skip to content

Fix SourceLink advisory and pin patched .NET SDK - #98

Open
Tamir Dresher (tamirdresher) wants to merge 1 commit into
mainfrom
tamirdresher-microsoft-fix-sourcelink-security-advisory
Open

Fix SourceLink advisory and pin patched .NET SDK#98
Tamir Dresher (tamirdresher) wants to merge 1 commit into
mainfrom
tamirdresher-microsoft-fix-sourcelink-security-advisory

Conversation

@tamirdresher

@tamirdresher Tamir Dresher (tamirdresher) commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix the baseline .NET restore failure caused by GHSA-23fw-v26w-5fgq / CVE-2026-62900.

Changes

  • Update Microsoft.SourceLink.GitHub from 8.0.0 to 10.0.111.
  • Update the declared .NET SDK from 10.0.301 to 10.0.303.
  • Keep the existing SDK roll-forward and prerelease policies unchanged.

No production code, public API, runtime dependency, audit policy, warning suppression, or workflow behavior is changed.

Why both updates are needed

Microsoft.SourceLink.GitHub 8.0.0 brings in the affected Microsoft.Build.Tasks.Git 8.0.0. Updating only the NuGet package is not sufficient because the .NET SDK also bundles SourceLink and Git build tasks that can take precedence during execution.

10.0.111 is the first stable SourceLink version available through Microsoft CFS with the patched Git and Common task packages. SDK 10.0.303 contains the corresponding patched SDK task set in the existing 10.0.3xx feature band.

Validation

Validation used exact SDK 10.0.303 and Microsoft CFS only:

  • Reproduced the original NU1902 warnings-as-errors restore failure with the previous versions.
  • Full solution restore completed with audit enabled and zero warnings or errors.
  • Full non-incremental Release build completed with zero warnings or errors.
  • DurableTask unit tests: 227 passed.
  • Azure Functions unit tests: 187 passed.
  • Both .nupkg and .snupkg package pairs were produced successfully.
  • dotnet format --verify-no-changes passed for all 359 files.
  • Package graph and payload checks confirm the change is limited to build tooling and does not add SourceLink task assemblies or runtime dependencies to the shipped packages.
  • GitHub build, test, pack, and format checks pass.
  • Both .NET and Python integration pipelines pass.

Scope

This is an independent build-tooling and security update. It does not depend on or modify the durable-history feature stack.

Update SourceLink GitHub to the smallest patched stable upgrade and move
the declared SDK to the patched 10.0.303 release in its existing feature band.
Keep transitive auditing and warnings-as-errors enabled.

Validated with exact SDK 10.0.303 through Microsoft CFS and accepted by
independent gpt-5.6-sol formal review before commit.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 532fe4f5-939b-4962-989d-a1883dccd283
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 11, 2026 21:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review findings remain.

Review tier: Lite
Findings: None

What changed in this PR

Updates build tooling to address the SourceLink advisory without changing production code.

Changes:

  • Pins the .NET SDK to 10.0.303.
  • Upgrades Microsoft.SourceLink.GitHub to 10.0.111.
File Description
dotnet/​global.json Updates the declared SDK version.
dotnet/​Directory.Packages.props Updates the centrally managed SourceLink package.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@tamirdresher
Tamir Dresher (tamirdresher) marked this pull request as ready for review September 12, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants