Enable detection cmake script for Visual Studio 2026 and pre-release versions of Visual Studio#14160
Open
andysterland wants to merge 3 commits intomicrosoft:masterfrom
Open
Enable detection cmake script for Visual Studio 2026 and pre-release versions of Visual Studio#14160andysterland wants to merge 3 commits intomicrosoft:masterfrom
andysterland wants to merge 3 commits intomicrosoft:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CMake build configuration to support Visual Studio 2026 and preview/insider builds of Visual Studio (both 2022 and 2026).
Changes:
- Updated the
vswhere.exeversion search range from[17.0,18.0)to[17.0,19.0)to include VS2026 (version 18.x) - Added the
-prereleaseflag to include preview and insider builds of Visual Studio - Added the
-latestflag to explicitly select the newest version when multiple installations are present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Updates to enable the creation of the .slnx file with Visual Studio 2026 and preview versions of Visual Studio (either 2022 or 2026).
PR Checklist
Detailed Description of the Pull Request / Additional comments
Update the args for calling
vswhereto:--prereleaseso that prerelease versions of Visual Studio are included in the search for VS installs, so preview and insiders installs will be found.--latestso that the latest version of VS is returned assuming the developer wants to use the latest version of VS this is optional but it seemed better to be explicit about which VS version will be selected if multiple are available.Validation Steps Performed
Ran
cmake .in a fresh repo with VS2026 installed.