Skip to content

fix: include available device IDs in device lookup error messages #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nuthalapativarun wants to merge 1 commit into
base: pre-release
Choose a base branch
from
Open

fix: include available device IDs in device lookup error messages #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions galaxy/client/device_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,11 @@ async def connect_device(
:return: True if connection successful
"""
if not self.device_registry.is_device_registered(device_id):
self.logger.error(f"❌ Device {device_id} not registered")
available_ids = list(self.device_registry.get_all_devices().keys())
self.logger.error(
f"❌ Device '{device_id}' not registered. "
f"Available device IDs: {available_ids}"
)
return False

device_info = self.device_registry.get_device(device_id)
Expand Down Expand Up @@ -562,7 +566,11 @@ async def assign_task_to_device(
# Check if device is registered and connected
device_info = self.device_registry.get_device(device_id)
if not device_info:
raise ValueError(f"Device {device_id} is not registered")
available_ids = list(self.device_registry.get_all_devices().keys())
raise ValueError(
f"Device '{device_id}' is not registered. "
f"Available device IDs: {available_ids}"
)

if device_info.status not in [
DeviceStatus.CONNECTED,
Expand Down Expand Up @@ -782,7 +790,11 @@ def get_device_status(self, device_id: str) -> Dict[str, Any]:
"""Get device status information"""
device_info = self.device_registry.get_device(device_id)
if not device_info:
return {"error": f"Device {device_id} not found"}
available_ids = list(self.device_registry.get_all_devices().keys())
return {
"error": f"Device '{device_id}' not found",
"available_device_ids": available_ids,
}

return {
"device_id": device_info.device_id,
Expand Down