Repository navigation
Fix hang in signature help due to loop in findPrecedingMatchingToken - #65006
Merged
Ryan Cavanaugh (RyanCavanaugh) merged 3 commits intoOct 29, 2026
Merged
Ryan Cavanaugh (RyanCavanaugh) merged 3 commits into
Ryan Cavanaugh (RyanCavanaugh) merged 3 commits into
Conversation
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the signature-help token-search fix and its regression test.
No open issues 🎉
What changed in this PR
Fixes a language-server signature-help hang by limiting token searches to text before the current token, preventing the search from moving forward and looping.
Changes:
- Restricts both delimiter searches in
findPrecedingMatchingTokento preceding text. - Adds a fourslash regression test verifying that incomplete syntax returns no signature help without hanging.
| File | Description |
|---|---|
tsc/internal/ls/utilities.go |
Bounds the token-search fast path to preceding text. |
tsc/internal/fourslash/tests/signatureHelpUnclosedParen_test.go |
Adds regression coverage for the signature-help hang. |
Review effort: Balanced
Jake Bailey (jakebailey)
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this while measuring LSP perf. This doesn't seem to happen in VS Code etc due to automatic paren insertion, but definitely hangs a straight-line edit sequence.