feat(lib/es2021): Add type parameter to FinalizationRegistry - #42274
Merged
Nathan Shively-Sanders (sandersn) merged 2 commits intoFeb 19, 2021
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Member
|
There's a lot of discussion on that issue and the linked PR. Can you add an explanation of why the type parameter is important? |
Contributor
Author
|
Because it makes the |
Nathan Shively-Sanders (sandersn)
requested review from
Orta Therox (orta) and
Nathan Shively-Sanders (sandersn)
January 16, 2021 00:46
Member
|
Is typical usage going to allow the type parameter to be inferred? I think it is, but it would be nice to have a test. |
Contributor
Author
|
Nathan Shively-Sanders (@sandersn) I’ve added a test case based on |
ExE Boss (ExE-Boss)
force-pushed
the
lib/es2021/typed-finalization-registry
branch
from
January 16, 2021 18:29
3502962 to
9f8c895
Compare
ExE Boss (ExE-Boss)
force-pushed
the
lib/es2021/typed-finalization-registry
branch
from
February 7, 2021 15:42
9f8c895 to
4ac2a13
Compare
Nathan Shively-Sanders (sandersn)
approved these changes
Feb 19, 2021
ExE Boss (ExE-Boss)
deleted the
lib/es2021/typed-finalization-registry
branch
February 19, 2021 01:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #32393
Fixes #38232 (comment)
Fixes #38232 (review)
review?(Orta Therox (@orta), Nathan Shively-Sanders (@sandersn))