Repository navigation
loopguard: pass over sudo, time and exec options before a test run - #240
Open
KVR Vishnu (VISHNU0906) wants to merge 1 commit into
Open
KVR Vishnu (VISHNU0906) wants to merge 1 commit into
KVR Vishnu (VISHNU0906) wants to merge 1 commit into
Conversation
status_of_tests only knew bare `time` and had no `sudo` or `exec`, so `sudo pytest`, `sudo -u bob python -m pytest`, `time -p pytest` and `exec pytest` were no verification and a failing run after the last edit left the turn green. Pass over them with their value-taking options, take `nice --adjustment 5`, and keep `command -v pytest` a lookup. Signed-off-by: KVR Vishnu <46535652+VISHNU0906@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Saksham Uboweja (@SakshamUboweja), one more on the verification side, next to #213.
_PREFIX_REinloopguard/turn.pypasses overenv,niceandtimeoutwith their options, but it had nosudoorexec, andtimeonly as a bare word. So these were not counted as test runs:sudo pytest -q,sudo -u bob python -m pytest,sudo -E npm testtime -p pytest,time -o t.txt npm testexec pytest,command -p pytest,nice --adjustment 5 pytestA failing one of these after the last edit left
resolved_proxy()True, the same problem #213 fixed forenv -uandnice -n.Now
sudois passed over with its value-taking options (-u,-g,-C,-D,--user=...and short clusters like-Eu bob),timewith-p/-v/-f/-o,execwith-a/-c/-l, andnice --adjustment Nwith a space.command -v pyteststill counts as nothing, since it only looks the runner up.Tests:
test_a_runner_behind_sudo_time_or_exec_counts_as_a_verificationgoes throughTurnGuard.foldlike the env/nice test, and all 12 cases fail withturn.pyfrom main. A second test pins the ones that should stay no run (command -v pytest,sudo make,sudo -l,--collect-only,time -p echo pytest).python -m pytest tests experiments/testspasses on Python 3.10 and 3.13, andscripts/dead_code.pyoutput is the same as on main.This is separate from #239 (micro-skills side) and touches a different file.