Repository navigation
fix(logging): apply the configured root level during initialization - #175
Open
yi-coding (xyi74976-del) wants to merge 1 commit into
Open
yi-coding (xyi74976-del) wants to merge 1 commit into
yi-coding (xyi74976-del) wants to merge 1 commit into
Conversation
|
yi-coding (@xyi74976-del) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start_logger()assigns_root_levelwithout declaring it global, so_apply_logging_levels()readsNoneor a stale value. For example, configuringLOGLEVEL=DEBUG,LOGLEVEL_CONSOLE=WARNINGandLOGLEVEL_FILE=OFFincorrectly sets both the root and TinyTroupe logger to WARNING, suppressing DEBUG records for other attached handlers. Reinitializing after a previous level has the same problem.Add
_root_levelto the existing global declaration and add four focused tests for startup, disabled TinyTroupe handlers, ordinary settings and reinitialization. The tests load the real stdlib-only configuration module in isolation and restore surrounding logging state.Validation: three regression cases fail on the original source and pass with the one-line fix; all four focused tests pass on Python 3.12. Python syntax, Pyflakes checks and formatting for the new test file pass. The SDK's full simulation suite was not run, and no model APIs were called. Pytest's default HTML/coverage options were disabled for this isolated utility run; the existing
timeout_exitconfiguration emits a warning in this environment.AI assistance: Codex investigated, implemented and tested this change at the account owner's request.