Skip to content

Dev #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nishant Yadav (nisyad-ms) merged 2 commits into from
Jun 25, 2026
Merged

Dev #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96aee61
fix env loader test fixture
nisyad-ms Jun 25, 2026
6e4dd19
Merge remote-tracking branch 'origin/main' into dev
nisyad-ms Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/test_env_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,12 @@ def _make_task(*, task_env_path: str | None) -> TaskDefinition:

def test_load_task_environment_uses_declared_task_env_for_customer_support() -> None:
domain = get_domain_config("customer_support")
task = _make_task(task_env_path="state_bench/domains/customer_support/task_envs/1-return_partial_order.json")
task_env_path = "state_bench/domains/customer_support/task_envs/1-hard_false_defect_phone_battery_settings.json"
task = _make_task(task_env_path=task_env_path)

env_data, env_path = load_task_environment(domain, task)

assert env_path == Path.cwd() / "state_bench/domains/customer_support/task_envs/1-return_partial_order.json"
assert env_path == Path.cwd() / task_env_path
assert len(env_data.orders) == 1


Expand Down Expand Up @@ -74,7 +75,9 @@ def test_task_definition_normalizes_null_state_requirements_to_empty_list() -> N


def test_task_definition_serializes_empty_state_requirements_as_list() -> None:
task = _make_task(task_env_path="state_bench/domains/customer_support/task_envs/1-return_partial_order.json")
task = _make_task(
task_env_path="state_bench/domains/customer_support/task_envs/1-hard_false_defect_phone_battery_settings.json"
)
task.state_requirements = []

payload = task.to_dict()
Expand Down
Loading