Support gif, bmp, xls, xlsx and pdf @ Write-RSFolderContent & Write-RsCatalogItem

[ClaudioESSilva]

Fixes
#214 (includes the changes on #215 that seems to have stood still)
#218
#221

Changes proposed in this pull request:

• Make possible to upload new file extensions. Namely: gif, bmp, xls, xlsx and pdf

NOTE: new Pester tests included

How to test this code:

• Try to upload a folder with at least one file of the mentioned types

Has been tested on (remove any that don't apply):

• Powershell 5.1
• Windows 10
• SQL Server 2016 and above

[ClaudioESSilva]

Hi @jtarquino ,

Can you, please, take a look at why .xlsx is yielding error?
SoapException: System.Web.Services.Protocols.SoapException: Uploading or saving files with .xlsx extension is not allowed. Contact your administrator if you have any questions. ---> Microsoft.ReportingServices.Diagnostics.ResourceFileFormatNotAllowedException: Uploading or saving files with .xlsx extension is not allowed. Contact your administrator if you have any questions.

I'm able to do it on my local instances (2016 SSRS & 2017 PBIRS).

Thanks!

[jtarquino]

Check AllowedResourceExtensionsForUpload https://docs.microsoft.com/en-us/power-bi/report-server/whats-new Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Cláudio Silva <notifications@github.com> Sent: Saturday, June 8, 2019 8:03:28 PM To: microsoft/ReportingServicesTools Cc: Jaime Tarquino; Mention Subject: Re: [microsoft/ReportingServicesTools] Support gif, bmp, xls, xlsx and pdf @ Write-RSFolderContent & Write-RsCatalogItem (#233) Hi @jtarquino<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjtarquino&data=02%7C01%7CJaime.Tarquino%40microsoft.com%7C5b1c9002196d4f640f9508d6ec6de6dd%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636956354102187523&sdata=G2lpy12lrgdbHcKD1efoTefJdH%2FtunyWD7ILlqMiCSo%3D&reserved=0> , Can you, please, take a look at why .xlsx is yielding error? SoapException: System.Web.Services.Protocols.SoapException: Uploading or saving files with .xlsx extension is not allowed. Contact your administrator if you have any questions. ---> Microsoft.ReportingServices.Diagnostics.ResourceFileFormatNotAllowedException: Uploading or saving files with .xlsx extension is not allowed. Contact your administrator if you have any questions. I'm able to do it on my local instances (2016 SSRS & 2017 PBIRS). Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FReportingServicesTools%2Fpull%2F233%3Femail_source%3Dnotifications%26email_token%3DAB5OLDW3XSMCAM7DN7S7QNLPZRCFBA5CNFSM4HWII4FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIA3LY%23issuecomment-500174255&data=02%7C01%7CJaime.Tarquino%40microsoft.com%7C5b1c9002196d4f640f9508d6ec6de6dd%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636956354102187523&sdata=b1UrDs2dWe9YCSlwEB9aRHBMWjZlqCtVsD4i7eDqveA%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB5OLDSFEKB2DJS7AP3XQ4DPZRCFBANCNFSM4HWII4FA&data=02%7C01%7CJaime.Tarquino%40microsoft.com%7C5b1c9002196d4f640f9508d6ec6de6dd%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636956354102197518&sdata=%2BKl0ffuabm%2Bpfx1CcLAH8jf3aRuztTUjKLoRbESxVeA%3D&reserved=0>.

[ClaudioESSilva]

Thanks @jtarquino
If I understood correctly, since the Jan 2019 release the extensions were trimmed for the ones in the documentation, but I see that is configurable.
The error seems to be on the SSRS (SOAP) and not on PBIRS (REST) , is this also configurable on SSRS?
Can you configure here on the repository installation script?

[jtarquino]

Yes it is configurable and it will be included in the new version of SSRS It affects both soap and rest I’m out of town and I can try to add them next week Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Cláudio Silva <notifications@github.com> Sent: Sunday, June 9, 2019 6:07:46 AM To: microsoft/ReportingServicesTools Cc: Jaime Tarquino; Mention Subject: Re: [microsoft/ReportingServicesTools] Support gif, bmp, xls, xlsx and pdf @ Write-RSFolderContent & Write-RsCatalogItem (#233) Thanks @jtarquino<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjtarquino&data=02%7C01%7CJaime.Tarquino%40microsoft.com%7C464a62ca5ee941656c5608d6ecc25278%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636956716690663135&sdata=Q7AlhQ2kg7VULNln3m7DXLM6l31kKtBQXRlx41oI2qk%3D&reserved=0> If I understood correctly, since the Jan 2019 release the extensions were trimmed for the ones in the documentation, but I see that is configurable. The error seems to be on the SSRS (SOAP) and not on PBIRS (REST) , is this also configurable on SSRS? Can you configure here on the repository installation script? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FReportingServicesTools%2Fpull%2F233%3Femail_source%3Dnotifications%26email_token%3DAB5OLDX7BLJC7QIWEXLG3N3PZTI7FA5CNFSM4HWII4FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIHJQY%23issuecomment-500200643&data=02%7C01%7CJaime.Tarquino%40microsoft.com%7C464a62ca5ee941656c5608d6ecc25278%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636956716690663135&sdata=ZTtUqHu5A0K4jRWUqwdZZ%2B7JMD0%2FFa5XzSAnumrNSPE%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB5OLDVUGF2OSLJG3VI6MXDPZTI7FANCNFSM4HWII4FA&data=02%7C01%7CJaime.Tarquino%40microsoft.com%7C464a62ca5ee941656c5608d6ecc25278%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636956716690673117&sdata=hWiisegtFv%2Bd6JyV7cejES0eJf7CDYRHXUukIVc9VVc%3D&reserved=0>.

[ClaudioESSilva]

Cool!
Then I will wait for the changes so we can double check that all tests pass and we can merge it!
Thanks for your help.

[jtarquino]

I added the config but there is a chance the service isn't ready for receiving it so I would recommend to add it to the test setup , check out

ReportingServicesTools/appveyor.yml

Line 91 in ccff67e

$newSettings = New-Object PSCustomObject -Property @{"PropertyValues" = @( @{"@odata.type"="#Model.Property"; "Name" = "AllowedResourceExtensionsForUpload"; "Value" = "*,*.xml,*.xsd,*.xsl,*.png,*.gif,*.jpg,*.tif,*.jpeg,*.tiff,*.bmp,*.pdf,*.svg,*.rtf,*.txt,*.doc,*.docx,*.pps,*.ppt,*.pptx,*.xlsx"})}

[ClaudioESSilva]

@jtarquino can you help?
Thanks

[jtarquino]

sure , as I mentioned earlier the file format wasn't applying always (added retries so now you can rely on it)

[ClaudioESSilva]

Thanks @jtarquino. It is still failing 😞

[jtarquino]

The db tests are probably the cause as they set the new database

I would add the setting of the allowed files to the tests that now require it (mostly to keep every test self contained), those tests are Write-RsFolderContent, Out-RsFolderContent, Write-RsCatalogItem etc

[kavishshaikh1]

Will it possible to also add .xlsm extensions to it?