MAINT: Simplifying GUI Feedback Buttons

[Richard Lundeen (rlundeen2)]

Summary

There were two ways to create feedback in the past, which was a bit confusing in the side panel. This PR adds the security link to the form itself.

Before

After

Testing

• npm test -- --runInBand src/components/Sidebar/Navigation.test.tsx src/components/Feedback/FeedbackDialog.test.tsx
• uv run --no-sync pre-commit run --all-files

[hannahwestra25]

i think the point of this link was to show people wehre there feedback was going to be posted (bc we have a bit of a hacky system in that it really just automates creating github issues), not to give the security policy but obviously this PR is indicative that that isn't clear (as in it might make sense to remove the link that indicates where the feedback is being aggregated). It makes sense to me to add the security policy link here but also the policy isn't specific to posting feedback so idk if we necessarily want to move it entirely. wdyt ?

[Richard Lundeen (rlundeen2)]

I like having it as one place and not separated. Users think in terms of "I need to tell the project something". And that might be a feature, security issue, etc. I've had two moments of minor confusion. 1) I thought the security icon meant security settings or something. 2) I was wondering where we'd report security issues and clicked on the feedback button first. I am pretty confident that people will think "security issue" or "bug" or "feature" and click on the right place.

But you're so right that it does put some cognitive burden after they open the feedback dialog and it made the form itself more confusing. I updated this to make the form better. I'm adding a "vulnerability" in the drop down, and then made it clear to follow the right process. WDYT about this?

[hannahwestra25]

I think part of the problem is (i think) they shared the same icon which does not read privacy policy at all imo so yeah 100% confusing. I think this makes sense but can you update the screenshots ?