Skip to content

MAINT: Remove additional initializer persistence - #2525

Merged
Behnam (behnam-o) merged 7 commits into
microsoft:mainfrom
behnam-o:behnam-o-remove-additional-initializers
Sep 2, 2026
Merged

MAINT: Remove additional initializer persistence#2525
Behnam (behnam-o) merged 7 commits into
microsoft:mainfrom
behnam-o:behnam-o-remove-additional-initializers

Conversation

@behnam-o

@behnam-o Behnam (behnam-o) commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Using both .pyrit_conf and database-backed additional initializers created two sources of truth for which initializers run in a backend. This removes the additional-initializer path so startup configuration comes only from .pyrit_conf, while keeping the GUI as a read-only view of that configuration.

Moved the "configured initializers" as a read-only tab under config. We can potentially expand on this and allow admins to edit pyrit_conf without modifying text directly and instead through some web UI to reduce human errors.
image

@behnam-o
Behnam (behnam-o) force-pushed the behnam-o-remove-additional-initializers branch from 2a32dea to 12f83e0 Compare September 1, 2026 19:24

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! only nits

Behnam Ousat and others added 6 commits September 1, 2026 15:17
Use .pyrit_conf as the single source for configured initializer startup behavior.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
Remove assertions for the deleted settings mutation routes after rebasing onto the config editor changes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
Show configured initializers as a read-only Configuration tab and remove the runtime apply path so initializer execution remains a startup concern.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
Handle the configuration request now made before opening the initializer tab.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
Keep the unrelated additional information wording unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
Keep the Scenario navigation assertion while removing the obsolete standalone Initializers entry.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
@behnam-o
Behnam (behnam-o) force-pushed the behnam-o-remove-additional-initializers branch from dca04a5 to 5643f5b Compare September 1, 2026 22:21
Comment thread frontend/src/App.tsx Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
@behnam-o
Behnam (behnam-o) added this pull request to the merge queue Sep 2, 2026
Merged via the queue into microsoft:main with commit 6d5b1a9 Sep 2, 2026
54 checks passed
@behnam-o
Behnam (behnam-o) deleted the behnam-o-remove-additional-initializers branch September 2, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants