-
Notifications
You must be signed in to change notification settings - Fork 7.6k
CmdPal: GEH per partes; part 1: error report builder, sanitizer and internals tools setting page #44140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jiripolasek
wants to merge
5
commits into
microsoft:main
Choose a base branch
from
jiripolasek:feature/41606-cmdpal-error-report-builder-and-sanitation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,102
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/modules/cmdpal/Core/Microsoft.CmdPal.Core.Common/Services/Sanitizer/UrlRuleProvider.cs
Fixed
Show fixed
Hide fixed
7 tasks
- Update label on the Internal page - Use Launcher to open log file / logs folder as DevRibbon - Use different icon for open logs folder card - Add button to quickly open a configuration folder (LocalState) - Block candidate pattern (\?:[^\)]+\|[^\)]+)
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Minor conflicts to resolve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR adds three parts of the original big bad global error handler (error report builder, sanitization and internal tools UI).
Error Report Generation
ErrorReportBuilder: Produces a detailed, technical report with system context.Example
Real-world example: #41362
PII Sanitization Framework
ErrorReportSanitizer: Multi-layer sanitization pipeline for sensitive data.PiiRuleProvider: Personally identifiable information (emails, phone numbers, SSNs).ProfilePathAndUsernameRuleProvider: Windows user profiles and usernames.NetworkRuleProvider: IP addresses, MAC addresses, network identifiers.SecretKeyValueRulesProvider: API keys, tokens, passwords in key/value formats.FilenameMaskRuleProvider: Sensitive file paths and extensions.UrlRuleProvider: URLs and web addresses.TokenRuleProvider: JWT and other auth tokens.ConnectionStringRuleProvider: Database connection strings.EnvironmentPropertiesRuleProvider: Environment variables and system properties.Internals Tools Page
A page in settings available in non-CI-builds:
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed