Skip to content

fix/reference copy#2046

Merged
baywet merged 10 commits intodevfrom
fix/reference-copy
Jan 21, 2025
Merged

fix/reference copy#2046
baywet merged 10 commits intodevfrom
fix/reference-copy

Conversation

@baywet
Copy link
Member

@baywet baywet commented Jan 8, 2025

partial #1998

@baywet baywet self-assigned this Jan 8, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 8, 2025
View reviewed changes
src/Microsoft.OpenApi/Services/CopyReferences.cs
{
internal class CopyReferences : OpenApiVisitorBase
private readonly OpenApiDocument _target = target;
public OpenApiComponents Components = new();

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'Components' can be 'readonly'.
@baywet baywet added this to the v2 - preview5 milestone Jan 8, 2025
@baywet
Copy link
Member Author

baywet commented Jan 17, 2025

@MaggieKimani1 I just had a thought: we could define a generic IOpenApiReferenceable interface, that derives from the existing interface, and defines the target property. Thoughts?

@MaggieKimani1
Copy link
Contributor

MaggieKimani1 commented Jan 20, 2025

@MaggieKimani1 I just had a thought: we could define a generic IOpenApiReferenceable interface, that derives from the existing interface, and defines the target property. Thoughts?

Yeah this seems like a cleaner approach for designing the proxy classes. Let me implement this.

@MaggieKimani1 MaggieKimani1 marked this pull request as ready for review January 20, 2025 17:10
@baywet baywet enabled auto-merge January 20, 2025 20:17
@baywet
Copy link
Member Author

baywet commented Jan 20, 2025

@MaggieKimani1 since I created this PR, I can't approve it, but I'm happy with the current content.
I think you can approve and merge it.

Also, when that is done, can you put together a release PR please? (bump preview versions)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 20, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
27.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@baywet baywet merged commit 995528e into dev Jan 21, 2025
13 of 14 checks passed
@baywet baywet deleted the fix/reference-copy branch January 21, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@gavinbarron gavinbarron Awaiting requested review from gavinbarron

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@andrueastman andrueastman Awaiting requested review from andrueastman

1 more reviewer

@MaggieKimani1 MaggieKimani1 MaggieKimani1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@baywet baywet

Labels

None yet

Projects

None yet

Milestone

v2 - preview5

Development

Successfully merging this pull request may close these issues.

2 participants

@baywet @MaggieKimani1