Fix ONNX save crash when ModelProto.ByteSize() raises EncodeError#2355
Open
anujj wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix ONNX save crash when ModelProto.ByteSize() raises EncodeError#2355anujj wants to merge 1 commit intomicrosoft:mainfrom
anujj wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@jambayk for review |
|
Also adding @devang-ml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a crash in ONNX model saving for large/complex models where
model.ByteSize()can raise a protobufEncodeError(Failed to serialize proto).Problem
In
model_proto_to_file, we probe model size withmodel.ByteSize()whensave_as_external_data=False.For some models, that call fails before save, causing the pass to crash.
Root Cause
ByteSize()can trigger protobuf serialization internals and fail with:google.protobuf.message.EncodeError: Failed to serialize proto.Fix
model.ByteSize()intry/except.save_as_external_data=True.<= 0or>= onnx.checker.MAXIMUM_PROTOBUF).Validation
mq:matmulnbitstoqdqflow.ByteSize()crash.Impact
ByteSize()works.