Issue 835 - support for loopMIDI and similar#849
Draft
Psychlist1972 wants to merge 13 commits intomainfrom
Draft
Issue 835 - support for loopMIDI and similar#849Psychlist1972 wants to merge 13 commits intomainfrom
Psychlist1972 wants to merge 13 commits intomainfrom
Conversation
If you start up loopMIDI when the service is already running, all your existing ports will appear. Still working on support for ports added or removed after loopMIDI has already started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change refactors the KSA (MIDI 1.0) transport to base itself on Filter/Interface add/remove vs Device add/remove. As a result, it provides support for KS MIDI 1.0 driver-based software which enumerates a device, but does not add ports until later, like loopMIDI.
The work is wrapped in a feature enablement call (set to always enabled in this repo) to support Controlled Feature Rollout in Windows.
PR is draft until I've completed testing.
Fixes issue #835