Add live audio transcription streaming support to Foundry Local JS SDK#486
Add live audio transcription streaming support to Foundry Local JS SDK#486
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… API, sample restructure (#538) Resolves all 23 review comments on the live audio transcription PR (`ruiren/audio-streaming-support-sdk`), including merge conflict resolution. Covers namespace fixes, a removed-but-needed public method, test file restoration, and sample reorganization. ## SDK fixes (`sdk_v2/cs/src/`) - **`OpenAI/AudioClient.cs`**: Restored `TranscribeAudioStreamingAsync` public method — was accidentally removed; `AudioTranscriptionExample` depends on it - **`OpenAI/LiveAudioTranscriptionClient.cs`** + **`LiveAudioTranscriptionTypes.cs`**: Changed namespace `Microsoft.AI.Foundry.Local` → `Microsoft.AI.Foundry.Local.OpenAI` (consistent with `ToolCallingExtensions.cs`, `AudioTranscriptionRequestResponseTypes.cs`); added required `using Microsoft.AI.Foundry.Local;` - **`OpenAI/LiveAudioTranscriptionClient.cs`**: Removed unused `using System.Runtime.InteropServices` (would fail build with `TreatWarningsAsErrors=true`); fixed XML doc `PushAudioAsync` → `AppendAsync`; removed leftover `#pragma warning disable` directives; cleaned up double blank lines - **`OpenAI/LiveAudioTranscriptionTypes.cs`**: Removed `Confidence` property — not populated by any code path - **`AssemblyInfo.cs`**: Removed `InternalsVisibleTo("AudioStreamTest")` — local dev artifact, not for shipped SDK ## Test fix (`sdk_v2/cs/test/`) - **`Utils.cs`**: Restored original `Microsoft.AI.Foundry.Local.Tests.Utils` class from main — file was completely overwritten with a top-level executable test script, breaking all existing tests that reference `Utils.CoreInterop`, `Utils.IsRunningInCI`, etc. ## Sample restructure (`samples/cs/`) - Removed standalone `samples/cs/LiveAudioTranscription/` (csproj, Program.cs, README) - Added `samples/cs/GettingStarted/src/LiveAudioTranscriptionExample/Program.cs` — follows `HelloFoundryLocalSdk` pattern using `Utils.GetAppLogger()`, `Utils.RunWithSpinner()`, `catalog.GetModelAsync()`; removed hardcoded DLL paths, model cache dir override, `BitsPerSample=16` (property doesn't exist), and debug diagnostics - Added cross-platform and Windows `.csproj` files under `GettingStarted/cross-platform/` and `GettingStarted/windows/` matching the structure of `AudioTranscriptionExample` > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `0t3vsblobprodcus362.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/B2063432E236EB2499F756DC7AEAC028/missingpackages_workingdir --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/nugetconfig/nuget.config --force ng/emptyFakeDotnetRoot ing/emptyFakeDotnetRoot` (dns block) > - `1javsblobprodcus364.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/Microsoft.AI.Foundry.Local.SDK.sln --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/CDD8923456756250B6AF4E42CA6F8DFB/missingpackages_workingdir --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/nugetconfig/nuget.config --force ng/emptyFakeDotnetRoot ing/emptyFakeDotnetRoot` (dns block) > - `1s1vsblobprodcus386.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/EFEB4E95C962CAA7DA01DE9B7C9E5F4D/missingpackages_workingdir --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/nugetconfig/nuget.config --force` (dns block) > - `4zjvsblobprodcus390.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/EFEB4E95C962CAA7DA01DE9B7C9E5F4D/missingpackages_workingdir --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/nugetconfig/nuget.config --force` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/79820580DC01B1F2024CE1D67DCA3751/missingpackages_workingdir --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/nugetconfig/nuget.config --force ng/emptyFakeDotnetRoot ing/emptyFakeDotnetRoot` (dns block) > - `51yvsblobprodcus36.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/Microsoft.AI.Foundry.Local.SDK.sln --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/src/Microsoft.AI.Foundry.Local.csproj --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/CDD8923456756250B6AF4E42CA6F8DFB/missingpackages_workingdir --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/nugetconfig/nuget.config --force ng/emptyFakeDotnetRoot ing/emptyFakeDotnetRoot` (dns block) > - `80zvsblobprodcus35.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/EFEB4E95C962CAA7DA01DE9B7C9E5F4D/missingpackages_workingdir --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/nugetconfig/nuget.config --force` (dns block) > - `aiinfra.pkgs.visualstudio.com` > - Triggering command: `/opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/samples/cs/GettingStarted/cross-platform/FoundrySamplesXPlatform.sln --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/samples/cs/GettingStarted/cross-platform/AudioTranscriptionExample/AudioTranscriptionExample.csproj --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - `c50vsblobprodcus330.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/Microsoft.AI.Foundry.Local.SDK.sln --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/test/FoundryLocal.Tests/Microsoft.AI.Foundry.Local.Tests.csproj --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - `frdvsblobprodcus327.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/test/FoundryLocal.Tests/Microsoft.AI.Foundry.Local.Tests.csproj --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - `i1qvsblobprodcus353.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/Microsoft.AI.Foundry.Local.SDK.sln --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/test/FoundryLocal.Tests/Microsoft.AI.Foundry.Local.Tests.csproj --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - `imzvsblobprodcus368.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/Microsoft.AI.Foundry.Local.SDK.sln --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/src/Microsoft.AI.Foundry.Local.csproj --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - `k0ivsblobprodcus356.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/B2063432E236EB2499F756DC7AEAC028/missingpackages_workingdir --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/nugetconfig/nuget.config --force ng/emptyFakeDotnetRoot ing/emptyFakeDotnetRoot` (dns block) > - `kxqvsblobprodcus376.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/Microsoft.AI.Foundry.Local.SDK.sln --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/test/FoundryLocal.Tests/Microsoft.AI.Foundry.Local.Tests.csproj --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - `m16vsblobprodcus374.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/EFEB4E95C962CAA7DA01DE9B7C9E5F4D/missingpackages_workingdir --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/nugetconfig/nuget.config --force` (dns block) > - `s8mvsblobprodcus38.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/Microsoft.AI.Foundry.Local.SDK.sln --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/src/Microsoft.AI.Foundry.Local.csproj --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/EFEB4E95C962CAA7DA01DE9B7C9E5F4D/missingpackages_workingdir --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/nugetconfig/nuget.config --force` (dns block) > - `se1vsblobprodcus349.vsblob.vsassets.io` > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/Microsoft.AI.Foundry.Local.SDK.sln --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Foundry-Local/Foundry-Local/sdk_v2/cs/src/Microsoft.AI.Foundry.Local.csproj --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true` (dns block) > - Triggering command: `/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/63E6685CBF8FE43B2889F9BB97016C00/missingpackages_workingdir --packages /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1a696f058c3bb324/dbs/csharp/working/nugetconfig/nuget.config --force` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/microsoft/Foundry-Local/settings/copilot/coding_agent) (admins only) > > </details> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> ## Context PR #485 (branch `ruiren/audio-streaming-support-sdk` targeting `main`) in microsoft/Foundry-Local adds live audio transcription streaming support to the Foundry Local C# SDK. It currently has merge conflicts with `main` and 23 review comments from Copilot bot and @kunal-vaishnavi that all need to be resolved. ## Task 1: Merge main branch and resolve conflicts The PR's `mergeable_state` is "dirty". Merge `main` into `ruiren/audio-streaming-support-sdk` and resolve all conflicts, ensuring the PR author's new code is preserved while incorporating any changes from main. ## Task 2: Resolve ALL of the following review comments ### SDK Source Code Fixes: 1. **`sdk/cs/src/Detail/JsonSerializationContext.cs`**: The file is in namespace `Microsoft.AI.Foundry.Local.Detail` but references `LiveAudioTranscriptionResult` and `CoreErrorResponse` which will be in namespace `Microsoft.AI.Foundry.Local.OpenAI` (see fix #8 below). Add a `using Microsoft.AI.Foundry.Local.OpenAI;` statement (this using may already exist from main, just ensure the types resolve correctly after the namespace change). 2. **`sdk/cs/src/OpenAI/AudioClient.cs`**: The public `TranscribeAudioStreamingAsync(...)` method was removed in the PR but the private `TranscribeAudioStreamingImplAsync(...)` still exists. **Restore the public `TranscribeAudioStreamingAsync` method** that wraps the private impl. This is used by speech-to-text models like Whisper and must NOT be removed. The original version from main is: ```csharp public async IAsyncEnumerable<AudioCreateTranscriptionResponse> TranscribeAudioStreamingAsync( string audioFilePath, [EnumeratorCancellation] CancellationToken ct) { var enumerable = Utils.CallWithExceptionHandling( () => TranscribeAudioStreamingImplAsync(audioFilePath, ct), "Error during streaming audio transcription.", _logger).ConfigureAwait(false); await foreach (var item in enumerable) { yield return item; } } ``` 3. **`sdk/cs/src/OpenAI/LiveAudioTranscriptionClient.cs`**: - Remove `using System.Runtime.InteropServices;` — it is unused and `TreatWarningsAsErrors=true` means this will cause CS8019 build failure. - Fix the XML doc comment that says "Thread safety: PushAudioAsync can be called from any thread" — change it to reference `AppendAsync` instead of `PushAudioAsync`. - Remove `#pragma warning disable` directives if they are not necessary. The reviewer asked why they're needed — they appear to be from development and should be removed for a clean PR. 4. **`sdk/cs/src/OpenAI/LiveAudioTranscriptionTypes.cs`**: - Change namespace from `Microsoft.AI.Foundry.Local` to `Microsoft.AI.Foundry.Local.OpenAI` (since the file is in the OpenAI folder, it should match the folder-based namespace convention used by the rest of the codebase). - Remove the `Confidence` property from `LiveAudioTranscriptionResult` if it is not being calculated/populated. The reviewer asked and it appears not to be calculated. 5. **`sdk/cs/src/OpenAI/LiveAudioTranscriptionClient.cs`**: - Also change namespace from `Microsoft.AI.Foundry.Local` to `Microsoft.AI.Foundry.Local.OpenAI` (same reason as above — the file is in the OpenAI folder). 6. **`sdk/cs/src/Microsoft.AI.Foundry.Local.csproj`**: Remove the `InternalsVisibleTo("AudioStreamTest")` attribute/assembly attribute. This was only needed for local experimentation and should not be in the shipped SDK. 7. **Remove trailing blank lines** in any files that have extra trailing blank lines added by this PR. ### Test File Fix: 8. **`sdk/cs/test/FoundryLocal.Tests/Utils.cs`**: This file was completely rewritten in the PR with top-level executable code and a hardcoded Core DLL path. It must be **restored to its original content from main**. The original file defines the `Microsoft.AI.Foundry.Local.Tests.Utils` helper class with `TestCatalogInfo`, `AssemblyInit`, `CoreInterop`, `CreateCapturingLoggerMock`, `CreateCoreInteropWithIntercept`, `IsRunningInCI`, `BuildTestCatalog`, `GetRepoRoot` etc. Multiple tests reference `Utils.*` (e.g., `Utils.CoreInterop`, `Utils.IsRunningInCI`), so the test project won't compile without it. Restore it to match the version on `main` exactly. ### Sample Restructuring: 9. **Move the sample from `samples/cs/LiveAudioTranscription/`** to `samples/cs/GettingStarted/src/LiveAudioTranscriptionExample/`. The sample Program.cs should be placed there. 10. **Remove the standalone `samples/cs/LiveAudioTranscription/` directory** entirely (including the README.md in it — reviewer says it's good for internal docs but these samples are public-facing, and the existing GettingStarted README covers it). 11. **Create cross-platform `.csproj`** at `samples/cs/GettingStarted/cross-platform/LiveAudioTranscriptionExample/LiveAudioTranscriptionExample.csproj` following the format of the existing cross-platform AudioTranscriptionExample: ```xml <Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> <OutputType>Exe<... </details> <!-- START COPILOT CODING AGENT SUFFIX --> *This pull request was created from Copilot chat.* > <!-- START COPILOT CODING AGENT TIPS --> --- 🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. [Learn more about Advanced Security.](https://gh.io/cca-advanced-security) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rui-ren <15321482+rui-ren@users.noreply.github.com>
…dio-streaming-support-sdk-js # Conflicts: # sdk/js/src/openai/liveAudioTranscriptionClient.ts # sdk/js/src/openai/liveAudioTranscriptionTypes.ts # sdk_v2/cs/src/Microsoft.AI.Foundry.Local.csproj # sdk_v2/js/src/index.ts
…g-support-sdk # Conflicts: # sdk/js/test/openai/chatClient.test.ts
…treaming-support-sdk-js # Conflicts: # sdk/js/test/openai/chatClient.test.ts # sdk/rust/build.rs
| @@ -0,0 +1,369 @@ | |||
| import { CoreInterop } from '../detail/coreInterop.js'; | |||
| import { LiveAudioTranscriptionResult, tryParseCoreError } from './liveAudioTranscriptionTypes.js'; | |||
|
|
|||
There was a problem hiding this comment.
Can you add an E2E example in the samples folder using the JS SDK?
| return Object.freeze(copy) as LiveAudioTranscriptionSettings; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
There are some Copilot-raised issues with this file.
Major issues / likely bugs
1) audio_stream_push does not appear to send actual audio bytes (only length)
In pushLoop(), the command payload includes SessionHandle and AudioDataLength, but not the audioData buffer itself:
this.coreInterop.executeCommand("audio_stream_push", {
Params: {
SessionHandle: this.sessionHandle!,
AudioDataLength: audioData.length.toString()
}
});Unless CoreInterop.executeCommand implicitly reads from some shared memory or side channel (not shown here), this looks like a functional bug: the core can’t transcribe audio it never receives. At minimum, this deserves a comment explaining the data path; ideally, pass bytes explicitly (e.g., AudioDataBase64, AudioData, or a binary channel supported by CoreInterop).
Recommendation: confirm the expected contract for "audio_stream_push" and update the call to include the buffer (or document how CoreInterop transfers it).
2) AsyncQueue backpressure is not safe for “multiple producers”
The comment says: “multiple producers writing” but the implementation has a single backpressureResolve slot:
- If the queue is full,
write()storesthis.backpressureResolve = resolve. - If two producers call
write()while full, the second overwrites the first resolver and the first producer can hang forever.
Also, tryWrite() ignores maxCapacity entirely and can grow memory unbounded even when a capacity was configured—this defeats the point of pushQueueCapacity.
Recommendation (choose one):
- Make
AsyncQueueexplicitly single-producer and enforce/document it; or - Fix it for real multi-producer backpressure by maintaining a FIFO of pending resolvers (e.g.,
backpressureResolvers: Array<() => void>), and enforce capacity intryWrite(returnfalsewhen full).
3) Potential “lost wakeup” / fairness issues in backpressure release
The consumer iterator releases backpressure when queue.length < maxCapacity, but only one waiter can be released (backpressureResolve is a single slot). Even with a single producer, this can create awkward behavior under bursty load; with multiple producers it’s incorrect as noted above.
Lifecycle / concurrency concerns
Stop ordering is a bit odd (abort happens after draining)
stop() does:
this.pushQueue?.complete()(drain then end)await this.pushLoopPromisethis.sessionAbortController?.abort()
But abort() can’t influence the loop if you’ve already awaited it. If your intent is “stop now, don’t drain”, you’d abort first. If your intent is “drain then stop”, you don’t need abort at all (except maybe to stop other background tasks).
Recommendation: decide semantics and align:
- Drain semantics: remove abort checks from push loop, or keep them but don’t call
abort()(or call it earlier only for external cancellation). - Immediate stop semantics:
abort()first, thenpushQueue.complete()(optionally with an error), thenawait pushLoopPromise.
Push calls during/after stop
pushAudioData() checks this.stopped, so once stop() sets stopped = true, further pushes throw (good). But if someone calls pushAudioData() concurrently right as stop begins, it may pass the check and then block forever if the queue is completed (your write() throws if completed, so it should reject—good), but consider race windows if pushQueue becomes null in the future refactor.
Error handling / API ergonomics
start()catch callsthis.outputQueue.complete()but doesn’t pass the error. That means consumers see a normal completion rather than failure if they started reading early.- Recommendation:
this.outputQueue.complete(err)sogetTranscriptionStream()fails loudly.
- Recommendation:
stop()alwaysthis.outputQueue?.complete()even if there was a fatal push error already set. BecauseAsyncQueue.complete()no-ops if already completed, this is fine.- Consider surfacing the native error in a typed way rather than embedding parsed
codeinto a string. You already havetryParseCoreError(); you could add a custom error class withcodefield.
Performance considerations
AsyncQueueusesArray.shift()which is O(n) per item due to reindexing. For audio streaming, this could become a hotspot.- Recommendation: implement the queue as a ring buffer or keep a
headIndexand occasionally compact.
- Recommendation: implement the queue as a ring buffer or keep a
pushAudioData()always copies the buffer. This is safe but can be expensive at high throughput.- Recommendation: if callers already supply immutable chunks, consider an opt-in “no copy” mode (documented), or accept
ArrayBufferand slice appropriately.
- Recommendation: if callers already supply immutable chunks, consider an opt-in “no copy” mode (documented), or accept
Minor style / maintainability notes
LiveAudioTranscriptionSettings.snapshot()returnsObject.freeze(copy) as LiveAudioTranscriptionSettings; consider returningReadonly<LiveAudioTranscriptionSettings>for better typing.AsyncQueue.errorgetter is unused in this file; either use it or remove it to reduce surface area.console.error/console.warnin a library can be noisy. Consider injecting a logger or using an internal debug hook.
Suggested concrete changes (priority order)
- Fix/confirm audio bytes transport in
"audio_stream_push"(most critical). - Fix
AsyncQueuemulti-producer backpressure (or document it’s single-producer), and enforce capacity intryWrite. - Replace
Array.shift()with a more efficient queue structure. - Propagate startup errors to stream consumers by completing
outputQueuewith the error. - Clarify stop semantics (drain vs immediate cancel) and adjust abort usage accordingly.
| } | ||
|
|
||
| try { | ||
| this.coreInterop.executeCommand("audio_stream_push", { |
There was a problem hiding this comment.
Shouldn't this be executeCommandWithBinary instead? You may need to modify interop for JS as you did for C# to add it.
Here's the updated PR description with the renamed types:
Title: Add live audio transcription streaming support to Foundry Local JS SDK
Description:
Adds real-time audio streaming support to the Foundry Local JS SDK, enabling live microphone-to-text transcription via ONNX Runtime GenAI ASR.
The existing
AudioClientonly supports file-based transcription. This PR introducesLiveAudioTranscriptionClientthat accepts continuous PCM audio chunks (e.g., from a microphone) and returns partial/final transcription results as an async iterable.What's included
New files
src/openai/liveAudioTranscriptionClient.ts— Streaming client withstart(),pushAudioData(),getTranscriptionStream(),stop(),dispose()src/openai/liveAudioTranscriptionTypes.ts—LiveAudioTranscriptionResultandCoreErrorResponseinterfaces,tryParseCoreError()helperModified files
src/imodel.ts— AddedcreateLiveTranscriptionClient()to interfacesrc/model.ts— Delegates toselectedVariant.createLiveTranscriptionClient()src/modelVariant.ts— Implementation (createsnew LiveAudioTranscriptionClient(modelId, coreInterop))src/index.ts— ExportsLiveAudioTranscriptionClient,LiveAudioTranscriptionSettings,LiveAudioTranscriptionResult,CoreErrorResponseAPI surface
Design highlights
AsyncQueue<T>serializes audio pushes from any context (safe for mic callbacks) and provides backpressure. Mirrors C#'sChannel<T>pattern.Object.freeze()d atstart(), immutable during the sessionpushAudioData()copies the inputUint8Arraybefore queueing, safe when caller reuses buffersstop()completes the push queue, waits for the push loop to drain, then calls native stopdispose()wrapsstop()in try/catch, never throwsNative core dependency
This PR adds the JS SDK surface. The 3 native commands (
audio_stream_start,audio_stream_push,audio_stream_stop) are routed through the existingexecute_command/execute_command_with_binaryexports. The code compiles with zero TypeScript errors without the native library.Testing
Parity with C# SDK
This implementation mirrors the C#
LiveAudioTranscriptionSession(branchruiren/audio-streaming-support-sdk) with identical logic:start→push→getStream→stopLiveAudioTranscription*(matching C# rename)