Skip to content

chore: dev to main merge#131

Open
Saswato-Microsoft wants to merge 36 commits intomainfrom
dev
Open

chore: dev to main merge#131
Saswato-Microsoft wants to merge 36 commits intomainfrom
dev

Conversation

@Saswato-Microsoft
Copy link
Copy Markdown

Purpose

This pull request introduces several improvements and clarifications to the deployment process, infrastructure configuration, and documentation for the accelerator. The main changes enhance automation for service principal handling, clarify and standardize VM credential management, update quota check instructions, and improve workflow triggers and environment variable handling for CI/CD. These updates aim to make deployments more reliable, transparent, and user-friendly.

Infrastructure and Workflow Automation:

  • Service principal handling is now automated: the workflows resolve and set AZURE_PRINCIPAL_ID dynamically if not provided, and use AZURE_PRINCIPAL_TYPE with a default of 'ServicePrincipal'. This ensures correct role assignments and RBAC configuration during deployment. (.github/workflows/azure-dev.yml, infra/main.bicepparam, [1] [2] [3]
  • The GitHub Actions workflows now check out submodules recursively and are triggered only on infrastructure-related changes, reducing unnecessary runs and ensuring all dependencies are present. (.github/workflows/azd-template-validation.yml, .github/workflows/azure-dev.yml, [1] [2] [3]

VM Credential Management and Documentation:

  • The process for setting and retrieving Jump VM admin credentials is standardized: environment variables (VM_ADMIN_USERNAME, VM_ADMIN_PASSWORD) are now the recommended method, with clear fallbacks and defaults (testvmuser for username, a default password). Documentation is updated to reflect this across guides and troubleshooting sections. (infra/main.bicepparam, docs/ACCESSING_PRIVATE_RESOURCES.md, docs/deploymentguide.md, docs/post_deployment_steps.md, [1] [2] [3] [4] [5]

Quota Check and Model/Capacity Documentation:

  • The quota check documentation is expanded to cover both AI model and Microsoft Fabric capacity requirements, with updated default values, sample output, and clear instructions for both Bash and PowerShell usage. (docs/quota_check.md, [1] [2]

Other Notable Improvements:

  • The required Bicep version is now specified in azure.yaml to ensure compatibility. (azure.yaml, azure.yamlR5)
  • Resource group creation is automated in the workflow if it does not exist, further reducing manual setup steps. (.github/workflows/azure-dev.yml, .github/workflows/azure-dev.ymlL27-R96)

Let me know if you want to walk through any of these changes in detail or see how they impact your development workflow!

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Harmanpreet-Microsoft and others added 30 commits March 30, 2026 14:24
chore: Update post-release process steps and fix deployment issues
Roopan-Microsoft and others added 6 commits April 9, 2026 11:35
fix: add bicep version requirement (>= 0.33.0) to azure.yaml
ci: Enhance Azure Dev workflow with submodule support and service principal configuration
fix: Set functional default VM admin password and credential params
feat: Add quota check scripts for Azure OpenAI models and Fabric capacity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants