Shutdown nodes on recovery-with-wrong-identity #7541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds exception handling to the test_recover_service_with_wrong_identity test function to ensure proper cleanup of network nodes when errors occur during recovery testing.
Key Changes
- Wraps the recovery test logic in a try-except block (lines 413-552)
- Adds exception handler that sets
ignoring_shutdown_errors, stops all nodes, and re-raises the exception (lines 554-557)
maxtropets
added
run-long-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Long Test passed
Indentation + manual catching.
Please share better ideas if you know how to elegantly release an object from the context manager, I didn't find any.